Bug 1246626
| Summary: | [PATCH] Please depend on policycoreutils-python-utils | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] vdsm | Reporter: | Tomas 'Sheldon' Radej <tradej> | ||||
| Component: | General | Assignee: | Yaniv Bronhaim <ybronhei> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Lukas Svaty <lsvaty> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | --- | CC: | bazulay, bugs, danken, dougsland, ecohen, fsimonce, gklein, lsurette, lsvaty, mgoldboi, oourfali, rbalakri, tradej, ybronhei, ycui, yeylon | ||||
| Target Milestone: | ovirt-3.6.1 | Flags: | ybronhei:
ovirt-3.6.z?
rule-engine: planning_ack? rule-engine: devel_ack+ rule-engine: testing_ack+ |
||||
| Target Release: | 4.17.11 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | infra | ||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2015-12-16 12:20:26 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1246603 | ||||||
| Attachments: |
|
||||||
|
Description
Tomas 'Sheldon' Radej
2015-07-24 17:20:14 UTC
Created attachment 1055846 [details]
Patch for SPEC file
Hi Tomas, Thanks for the patch! However, the package is still not available in fedora 22 so neither el7 nor any fedora<23 can't have such dependency yet. Can you please upload your patch to gerrit.ovirt.org for review and verification by our CI jobs? This package will exist only in Fedora 23 onwards, and will not be backported (meaning both in Fedora and EPEL). I'm afraid that if you want to maintain only one SPEC file, adding some conditionals will be necessary. please review https://gerrit.ovirt.org/#/c/44019/ . I still don't have fedora 23 to verify it on.. If you can try to install and see that the requirements are set alright with that patch it will be appreciated Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. [root@dell-r210ii-11 ~]# rpm -q vdsm vdsm-4.17.13-1.el7ev.noarch [root@dell-r210ii-11 ~]# repoquery --requires vdsm | grep policycore policycoreutils-python Lukas, what OS was this tested in? F23? Red Hat Enterprise Linux Server release 7.2 (Maipo) Does vdsm have different spec file for rhel7 and Fedora23? (In reply to Lukas Svaty from comment #8) > Red Hat Enterprise Linux Server release 7.2 (Maipo) > > Does vdsm have different spec file for rhel7 and Fedora23? Seems like it is. See the patch for this bug: https://gerrit.ovirt.org/#/c/48004/2/vdsm.spec.in I agree, the patch should be tested only on F23. Moving back to ON_QA
However in patch:
shouldnt we drop policycoreutils-python requirement in F23 as it was moved to mentioned package and require it only for other distros?
%if 0%{?fedora} >= 23
Requires: policycoreutils-python-utils
%endif # fedora 23
Requires: policycoreutils-python <<-- this line not for F23
Moving needinfo to Yaniv. on F23: [root@dell-r210ii-11 ~]# repoquery --requires vdsm | grep policycore | grep python-utils policycoreutils-python-utils moving to VERIFIED Yaniv: BZ tracking this here: https://bugzilla.redhat.com/show_bug.cgi?id=1290437 According to verification status and target milestone this issue should be fixed in oVirt 3.6.1. Closing current release. Yes, we do differ between different distributions in the spec file. I added a comment in Bug #1290437 about this issue |