Bug 1246626 - [PATCH] Please depend on policycoreutils-python-utils
Summary: [PATCH] Please depend on policycoreutils-python-utils
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: General
Version: ---
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-3.6.1
: 4.17.11
Assignee: Yaniv Bronhaim
QA Contact: Lukas Svaty
URL:
Whiteboard: infra
Depends On:
Blocks: 1246603
TreeView+ depends on / blocked
 
Reported: 2015-07-24 17:20 UTC by Tomas 'Sheldon' Radej
Modified: 2016-02-10 19:06 UTC (History)
16 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-12-16 12:20:26 UTC
oVirt Team: Infra
Embargoed:
ybronhei: ovirt-3.6.z?
rule-engine: planning_ack?
rule-engine: devel_ack+
rule-engine: testing_ack+


Attachments (Terms of Use)
Patch for SPEC file (2.56 KB, application/octet-stream)
2015-07-24 17:20 UTC, Tomas 'Sheldon' Radej
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 44019 0 master MERGED Adding policycoreutils-python-utils dependency for fedora 23 and above Never
oVirt gerrit 48004 0 ovirt-3.6 MERGED Adding policycoreutils-python-utils dependency for fedora 23 and above Never

Description Tomas 'Sheldon' Radej 2015-07-24 17:20:14 UTC
Hello,

Your package depends on a utility from policycoreutils-python. The utilities
have been moved to a new package, policycoreutils-python-utils. Please, apply
the provided patch to fix your package as soon as possible because on Tuesday,
July 28, there is an Alpha Freeze and Change Freeze for Fedora 23.

Thank you very much, Tomas Radej

Comment 1 Tomas 'Sheldon' Radej 2015-07-24 17:20:19 UTC
Created attachment 1055846 [details]
Patch for SPEC file

Comment 2 Yaniv Bronhaim 2015-07-27 08:57:05 UTC
Hi Tomas, Thanks for the patch!

However, the package is still not available in fedora 22 so neither el7 nor any fedora<23 can't have such dependency yet.  

Can you please upload your patch to gerrit.ovirt.org for review and verification by our CI jobs?

Comment 3 Tomas 'Sheldon' Radej 2015-07-27 09:08:04 UTC
This package will exist only in Fedora 23 onwards, and will not be backported (meaning both in Fedora and EPEL). I'm afraid that if you want to maintain only one SPEC file, adding some conditionals will be necessary.

Comment 4 Yaniv Bronhaim 2015-07-27 10:15:40 UTC
please review https://gerrit.ovirt.org/#/c/44019/ . I still don't have fedora 23 to verify it on.. If you can try to install and see that the requirements are set alright with that patch it will be appreciated

Comment 5 Red Hat Bugzilla Rules Engine 2015-10-19 10:50:12 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 6 Lukas Svaty 2015-12-10 13:11:54 UTC
[root@dell-r210ii-11 ~]# rpm -q vdsm
vdsm-4.17.13-1.el7ev.noarch
[root@dell-r210ii-11 ~]# repoquery --requires vdsm | grep policycore
policycoreutils-python

Comment 7 Oved Ourfali 2015-12-10 13:14:23 UTC
Lukas, what OS was this tested in?
F23?

Comment 8 Lukas Svaty 2015-12-10 13:38:21 UTC
Red Hat Enterprise Linux Server release 7.2 (Maipo)

Does vdsm have different spec file for rhel7 and Fedora23?

Comment 9 Oved Ourfali 2015-12-10 13:39:36 UTC
(In reply to Lukas Svaty from comment #8)
> Red Hat Enterprise Linux Server release 7.2 (Maipo)
> 
> Does vdsm have different spec file for rhel7 and Fedora23?

Seems like it is.
See the patch for this bug:
https://gerrit.ovirt.org/#/c/48004/2/vdsm.spec.in

Comment 10 Lukas Svaty 2015-12-10 13:49:31 UTC
I agree, the patch should be tested only on F23. Moving back to ON_QA

However in patch:
shouldnt we drop policycoreutils-python requirement in F23 as it was moved to mentioned package and require it only for other distros?

%if 0%{?fedora} >= 23
Requires: policycoreutils-python-utils
%endif # fedora 23
Requires: policycoreutils-python              <<-- this line not for F23

Comment 11 Oved Ourfali 2015-12-10 13:53:29 UTC
Moving needinfo to Yaniv.

Comment 12 Lukas Svaty 2015-12-10 14:11:09 UTC
on F23:

[root@dell-r210ii-11 ~]# repoquery --requires vdsm | grep policycore | grep python-utils
policycoreutils-python-utils

moving to VERIFIED

Yaniv: BZ tracking this here:
https://bugzilla.redhat.com/show_bug.cgi?id=1290437

Comment 13 Sandro Bonazzola 2015-12-16 12:20:26 UTC
According to verification status and target milestone this issue should be fixed in oVirt 3.6.1. Closing current release.

Comment 14 Yaniv Bronhaim 2016-01-04 13:42:33 UTC
Yes, we do differ between different distributions in the spec file. I added a comment in Bug #1290437 about this issue


Note You need to log in before you can comment on or make changes to this bug.