Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://mayorga.fedorapeople.org/js-excanvas.spec SRPM URL: https://mayorga.fedorapeople.org/js-excanvas-0-0.1.gitae9e090.fc22.src.rpm Description: Firefox, Safari and Opera 9 support the canvas tag to allow 2D command-based drawing operations. ExplorerCanvas brings the same functionality to Internet Explorer; web developers only need to include a single script tag in their existing canvas webpages to enable this support. Fedora Account System Username: mayorga
can you review this one for me? https://bugzilla.redhat.com/show_bug.cgi?id=1224516
Build fails Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10479257 + cd /builddir/build/BUILD + cd /builddir/build/BUILD + rm -rf ExplorerCanvas-ae9e090609810a18ecb3345c628494b2f6c43ed9 + /usr/bin/gzip -dc /builddir/build/SOURCES/js-excanvas-ae9e090.tar.gz + /usr/bin/tar -xof - + STATUS=0 + '[' 0 -ne 0 ']' + cd ExplorerCanvas-ae9e090609810a18ecb3345c628494b2f6c43ed9 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + exit 0 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.CJJWCe + umask 022 + cd /builddir/build/BUILD + cd ExplorerCanvas-ae9e090609810a18ecb3345c628494b2f6c43ed9 ++ find -name '*.js' + for f in '`find -name "*.js"`' + bn=./silverlight/excanvas + bn=./silverlight/excanvas-min.js + slimit --mangle /var/tmp/rpm-tmp.CJJWCe: line 35: slimit: command not found error: Bad exit status from /var/tmp/rpm-tmp.CJJWCe (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.CJJWCe (%build) Child return code was: 1 EXCEPTION: Command failed. See logs for output. # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/js-excanvas.spec Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 84, in trace result = func(*args, **kw) File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 494, in do raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode) Error: Command failed. See logs for output. # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/js-excanvas.spec LEAVE do --> EXCEPTION RAISED
with closure-compiler see https://bugzilla.redhat.com/show_bug.cgi?id=1246759 you should add for Fedora <= 22 also BuildRequire: jarjar for f in `find -name "*.js"`; do bn="${f%.js}" bn="${bn}-min.js" closure-compiler --js=${f} >${bn} done
Spec URL: https://mayorga.fedorapeople.org/js-excanvas.spec SRPM URL: https://mayorga.fedorapeople.org/js-excanvas-0-0.2.gitae9e090.fc22.src.rpm * Sat Jul 25 2015 Eduardo Mayorga Téllez <mayorga> - 0-0.2.gitc5a4525 - Building minified version with closure-compiler
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)". Detailed output of licensecheck in /home/gil/1246783-js-excanvas/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/doc/js- excanvas/examples(languages, langpacks:, enabled, are, No), /usr/share/doc/js-excanvas(languages, langpacks:, enabled, are, No), /usr/share/javascript/excanvas/0(languages, langpacks:, enabled, are, No), /usr/share/licenses/js-excanvas(languages, langpacks:, enabled, are, No), /usr/share/javascript/excanvas(languages, langpacks:, enabled, are, No) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: js-excanvas-0-0.2.gitae9e090.fc23.noarch.rpm js-excanvas-0-0.2.gitae9e090.fc23.src.rpm js-excanvas.noarch: W: spelling-error %description -l en_US webpages -> web pages, web-pages, passages js-excanvas.noarch: W: incoherent-version-in-changelog 0-0.2.gitc5a4525 ['0-0.2.gitae9e090.fc23', '0-0.2.gitae9e090'] js-excanvas.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/js-excanvas/README js-excanvas.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/js-excanvas/AUTHORS js-excanvas.src: W: spelling-error %description -l en_US webpages -> web pages, web-pages, passages 2 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: File o directory non esistente js-excanvas.noarch: W: incoherent-version-in-changelog 0-0.2.gitc5a4525 ['0-0.2.gitae9e090.fc23', '0-0.2.gitae9e090'] js-excanvas.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/js-excanvas/README js-excanvas.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/js-excanvas/AUTHORS 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Requires -------- js-excanvas (rpmlib, GLIBC filtered): web-assets-filesystem Provides -------- js-excanvas: js-excanvas Source checksums ---------------- https://github.com/arv/ExplorerCanvas/archive/ae9e090609810a18ecb3345c628494b2f6c43ed9/js-excanvas-ae9e090.tar.gz : CHECKSUM(SHA256) this package : 039d897e00d0a53e3291a6b420d973f589fc32863a130fffb0942623907ce292 CHECKSUM(SHA256) upstream package : 039d897e00d0a53e3291a6b420d973f589fc32863a130fffb0942623907ce292 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/bin/fedora-review -b 1246783 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
NON blocking issues: js-excanvas.noarch: W: incoherent-version-in-changelog 0-0.2.gitc5a4525 ['0-0.2.gitae9e090.fc23', '0-0.2.gitae9e090'] js-excanvas.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/js-excanvas/README js-excanvas.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/js-excanvas/AUTHORS Please, fix those at import time suggestion: sed -i 's/\r//' AUTHORS README * Sat Jul 25 2015 Eduardo Mayorga Téllez <mayorga> - 0-0.2.gitae9e090 approved
New Package SCM Request ======================= Package Name: js-excanvas Short Description: Canvas for IE8 and older Upstream URL: https://github.com/arv/ExplorerCanvas Owners: mayorga Branches: f23 InitialCC:
Git done (by process-git-requests).