Bug 1247972 - quota/marker: lk_owner is null while acquiring inodelk in rename operation
Summary: quota/marker: lk_owner is null while acquiring inodelk in rename operation
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: quota
Version: 3.6.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vijaikumar Mallikarjuna
QA Contact:
URL:
Whiteboard:
Depends On: 1240598
Blocks: glusterfs-3.6.6
TreeView+ depends on / blocked
 
Reported: 2015-07-29 11:13 UTC by Vijaikumar Mallikarjuna
Modified: 2016-05-11 22:48 UTC (History)
5 users (show)

Fixed In Version: glusterfs-3.6.6
Clone Of: 1240598
Environment:
Last Closed: 2015-09-30 12:15:13 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Vijaikumar Mallikarjuna 2015-07-29 11:13:17 UTC
+++ This bug was initially created as a clone of Bug #1240598 +++

Before doing a rename operation marker takes inode lock on the file parent,
here lk_owner is NULL and this can cause accounting problem with multiple rename on the same directory

--- Additional comment from Anand Avati on 2015-07-07 06:41:14 EDT ---

REVIEW: http://review.gluster.org/11561 (quota/marker: set lk_owner when taking lock on parent in rename) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Anand Avati on 2015-07-07 08:57:01 EDT ---

REVIEW: http://review.gluster.org/11561 (quota/marker: set lk_owner when taking lock on parent in rename) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Anand Avati on 2015-07-10 00:09:00 EDT ---

COMMIT: http://review.gluster.org/11561 committed in master by Raghavendra G (rgowdapp) 
------
commit 7488acff20ef6ff8df76af07547695e0106f32ca
Author: vmallika <vmallika>
Date:   Tue Jul 7 16:03:26 2015 +0530

    quota/marker: set lk_owner when taking lock on parent in rename
    
    Before doing a rename operation marker takes inode lock on the file
    parent,
    here lk_owner is NULL and this can cause accounting problem with
    multiple rename on the same directory
    
    This patch fix the problem by setting lk_owner
    
    Change-Id: Ibb789e39b2833e425d0a5fca85282ff1465206cb
    BUG: 1240598
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/11561
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 1 Anand Avati 2015-07-29 11:15:57 UTC
REVIEW: http://review.gluster.org/11795 (quota/marker: set lk_owner when taking lock on parent in rename) posted (#1) for review on release-3.6 by Vijaikumar Mallikarjuna (vmallika)

Comment 2 Anand Avati 2015-08-14 08:58:19 UTC
REVIEW: http://review.gluster.org/11795 (quota/marker: set lk_owner when taking lock on parent in rename) posted (#2) for review on release-3.6 by Raghavendra Bhat (raghavendra)

Comment 3 Anand Avati 2015-08-19 07:28:23 UTC
REVIEW: http://review.gluster.org/11795 (quota/marker: set lk_owner when taking lock on parent in rename) posted (#3) for review on release-3.6 by Raghavendra Bhat (raghavendra)

Comment 4 Anand Avati 2015-08-27 08:33:26 UTC
REVIEW: http://review.gluster.org/11795 (quota/marker: set lk_owner when taking lock on parent in rename) posted (#5) for review on release-3.6 by Vijaikumar Mallikarjuna (vmallika)

Comment 5 Raghavendra Bhat 2015-09-21 06:50:08 UTC
http://review.gluster.org/#/c/11795/ has been merged.

Comment 6 Raghavendra Bhat 2015-09-30 12:15:13 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.6, please open a new bug report.

glusterfs-3.6.6 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/gluster-devel/2015-September/046821.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.