Bug 1251958 - VDSM: Live merge fails after a disk containing a snapshot has been extended
Summary: VDSM: Live merge fails after a disk containing a snapshot has been extended
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: vdsm
Version: 3.5.1
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-3.5.7
: 3.5.7
Assignee: Adam Litke
QA Contact: Aharon Canan
URL:
Whiteboard: storage
Depends On: 1232481
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-08-10 12:08 UTC by rhev-integ
Modified: 2019-07-16 11:33 UTC (History)
14 users (show)

Fixed In Version: vdsm-4.16.27-1
Doc Type: Bug Fix
Doc Text:
Clone Of: 1232481
Environment:
Last Closed: 2016-01-12 20:34:31 UTC
oVirt Team: Storage
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 1488453 0 None None None Never
Red Hat Product Errata RHBA-2016:0034 0 normal SHIPPED_LIVE vdsm 3.5.7 - bug fix and enhancement update 2016-01-13 01:29:23 UTC
oVirt gerrit 42836 0 master MERGED Live Merge: Prevent merge when base volume is too small Never
oVirt gerrit 42921 0 master MERGED Live merge: Update base size after live merge Never
oVirt gerrit 43407 0 master MERGED Live Merge: Allow extension of non-leaf raw volumes Never
oVirt gerrit 45104 0 ovirt-3.5 ABANDONED virt: Add _getVolumeInfo helper Never
oVirt gerrit 45105 0 ovirt-3.5 ABANDONED Live Merge: Allow extension of non-leaf raw volumes Never
oVirt gerrit 45106 0 ovirt-3.5 ABANDONED virt: Introduce Vm._setVolumeSize helper Never
oVirt gerrit 45107 0 ovirt-3.5 ABANDONED Live merge: Update base size after live merge Never
oVirt gerrit 45947 0 ovirt-3.5 MERGED virt: Add _getVolumeInfo helper Never
oVirt gerrit 45948 0 ovirt-3.5 MERGED Live Merge: Allow extension of non-leaf raw volumes Never
oVirt gerrit 45949 0 ovirt-3.5 MERGED virt: Introduce Vm._setVolumeSize helper Never
oVirt gerrit 45950 0 ovirt-3.5 MERGED Live merge: Update base size after live merge Never

Comment 1 Aharon Canan 2015-10-06 12:27:00 UTC 
Verified using the following versions:
---------------------------------------
rhevm-3.5.5-0.1.el6ev.noarch - running on Rhel6.7
vdsm-4.16.27-1.el7ev.x86_64 - running on Rhel7.1

Scenario 1:
----------------
1. Create a VM with 1gb preallocated disk (probably thin as well, didn't test that) in a block-based domain.
2. Create a snapshot.
3. Extend the disk to 2gb.
4. Start the VM.
5. Delete the snapshot - Live merge works well!


same verification like in https://bugzilla.redhat.com/show_bug.cgi?id=1241433 - same issue and 2 bugs - engine and vdsm
Comment 2 Adam Litke 2015-10-22 13:50:18 UTC 
This will fail when the VM is not running on an SPM host as described in bug 1274323
Comment 3 Adam Litke 2015-10-22 13:51:40 UTC 
Moving back to ASSIGNED per previous comment.
Comment 5 Yaniv Lavi 2015-10-28 14:07:57 UTC 
Why did you move this to 3.5.7?
Comment 6 Tal Nisan 2015-11-01 11:20:06 UTC 
See comment #2, the bug is not completely fixed
Comment 7 Adam Litke 2015-11-03 14:20:16 UTC 
Talked with Tal and we decided to move this back to MODIFIED and track the backport of bug 1274323 in a new clone.  It will just keep things simpler.

To re-verify, you can rerun the scenario in comment one ensuring that the VM runs on the SPM host.
Comment 8 Aharon Canan 2015-12-24 10:18:20 UTC 
Verified using the following versions:
---------------------------------------
rhevm-3.5.7-0.1.el6ev.noarch - running on Rhel6.7
vdsm-4.16.31-1.el7ev.x86_64 - running on Rhel7.2

Scenario 1:
----------------
1. Create a VM with 1gb preallocated disk (probably thin as well, didn't test that) in a block-based domain.
2. Create a snapshot.
3. Extend the disk to 2gb.
4. Start the VM on SPM.
5. Delete the snapshot

Scenario 2:
--------------------
1) Create a VM with 1gb preallocated disk in a block-based domain.
2) Create a snapshot.
3) Create a second snapshot.
4) Extend the disk to 2gb.
5) Start the VM on SPM.
6) Delete the second snapshot


Same flows on HSM will be verified on https://bugzilla.redhat.com/show_bug.cgi?id=1292129

Also, didn't face any errors like in https://bugzilla.redhat.com/show_bug.cgi?id=1232481#c28
Comment 11 errata-xmlrpc 2016-01-12 20:34:31 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0034.html
Note You need to log in before you can comment on or make changes to this bug.