+++ This bug was initially created as a clone of Bug #1242211 +++ Description of problem: ----------------------- There are few instances of 'gf_log' and 'gf_log_callingfn' seen under libglusterfs These instances needs to be ported to new logging framework Version-Release number of selected component (if applicable): ------------------------------------------------------------- RHGS-3.1 Nightly ( glusterfs-3.7.1-8.el6rhs ) Expected results: ----------------- All old log messages should be ported to new logging framework --- Additional comment from SATHEESARAN on 2015-07-12 13:18:07 EDT --- src/inode.c: gf_log_callingfn (THIS->name, GF_LOG_WARNING, src/inode.c- "inode not found"); [satheesaran@dhcppc1 libglusterfs]$ grep -r "gf_log " src/logging.h -B1 -A1 int _gf_log (const char *domain, const char *file, const char *function, int32_t line, gf_loglevel_t level, -- FMT_WARN (fmt); \ _gf_log (dom, __FILE__, __FUNCTION__, __LINE__, \ levl, ##fmt); \ -- #define GF_LOG_OCCASIONALLY(var, args...) if (!(var++%GF_UNIVERSAL_ANSWER)) { \ gf_log (args); \ } -- #define GF_DEBUG(xl, format, args...) \ gf_log ((xl)->name, GF_LOG_DEBUG, format, ##args) #define GF_INFO(xl, format, args...) \ gf_log ((xl)->name, GF_LOG_INFO, format, ##args) #define GF_WARNING(xl, format, args...) \ gf_log ((xl)->name, GF_LOG_WARNING, format, ##args) #define GF_ERROR(xl, format, args...) \ gf_log ((xl)->name, GF_LOG_ERROR, format, ##args) -- src/xlator.c: gf_log ("glusterfs", gf_log_get_loglevel(), src/xlator.c- "setting log level to %d (old-value=%d)", -- src/xlator.c: gf_log (this->name, gf_log_get_xl_loglevel (this), src/xlator.c- "setting log level to %d (old-value=%d)", -- src/xlator.c: gf_log (trav->name, gf_log_get_xl_loglevel (trav), src/xlator.c- "setting log level to %d (old-value=%d)", src/unittest/log_mock.c:int _gf_log (const char *domain, const char *file, src/unittest/log_mock.c- const char *function, int32_t line, gf_loglevel_t level, -- src/run.c: gf_log_callingfn (dom, lvl, "%s: %s", msg, buf); src/run.c- -- src/timespec.c: gf_log_callingfn ("timer", GF_LOG_TRACE, "%"GF_PRI_TIME".%09"GF_PRI_TIME, src/timespec.c- ts->tv_sec, ts->tv_nsec);
REVIEW: http://review.gluster.org/11896 (libglusterfs: Pending - Porting log messages to new framework) posted (#1) for review on master by Mohamed Ashiq Liyazudeen (mliyazud)
REVIEW: http://review.gluster.org/11896 (libglusterfs: Pending - Porting log messages to new framework) posted (#2) for review on master by Mohamed Ashiq Liyazudeen (mliyazud)
REVIEW: http://review.gluster.org/11896 (libglusterfs: Porting log messages to new framework) posted (#3) for review on master by Mohamed Ashiq Liyazudeen (mliyazud)
REVIEW: http://review.gluster.org/11896 (libglusterfs: Porting log messages to new framework) posted (#4) for review on master by Mohamed Ashiq Liyazudeen (mliyazud)
REVIEW: http://review.gluster.org/11896 (libglusterfs:Porting log messages to new framework) posted (#5) for review on master by Mohamed Ashiq Liyazudeen (mliyazud)
REVIEW: http://review.gluster.org/11896 (libglusterfs:Porting log messages to new framework) posted (#6) for review on master by Mohamed Ashiq Liyazudeen (mliyazud)
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user