Bug 1258714 - bug-948686.t fails spuriously
Summary: bug-948686.t fails spuriously
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Atin Mukherjee
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1258798 1282847
TreeView+ depends on / blocked
 
Reported: 2015-09-01 05:36 UTC by Atin Mukherjee
Modified: 2016-06-16 13:34 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1258798 1282847 (view as bug list)
Environment:
Last Closed: 2016-06-16 13:34:27 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Atin Mukherjee 2015-09-01 05:36:38 UTC
Description of problem:

bug-948686.t intermittely ends up in a race in GlusterD where one thread deletes
a stale volume and on a volume start request a start is attempted on the same   object which might be freed up by the other thread. We are considering to use  refcounting mechanism while accessing volinfo objects to get rid of this problem
but that needs a significant amount of time in development. Till then adding
this test in bad_tests ()

Version-Release number of selected component (if applicable):
Mainline

How reproducible:
Intermittent

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2015-09-01 05:37:21 UTC
REVIEW: http://review.gluster.org/12070 (tests: add bug-948686.t to bad_tests) posted (#1) for review on master by Atin Mukherjee (amukherj)

Comment 2 Anand Avati 2015-09-01 08:42:34 UTC
COMMIT: http://review.gluster.org/12070 committed in master by Raghavendra Talur (rtalur) 
------
commit 99cd07c596f74b1ee8a88c4a43b37eb0921e5fe2
Author: Atin Mukherjee <amukherj>
Date:   Tue Sep 1 10:53:19 2015 +0530

    tests: add bug-948686.t to bad_tests
    
    bug-948686.t intermittely ends up in a race in GlusterD where one thread deletes
    a stale volume and on a volume start request a start is attempted on the same
    object which might be freed up by the other thread. We are considering to use
    refcounting mechanism while accessing volinfo objects to get rid of this problem
    but that needs a significant amount of time in development. Till then adding
    this test in bad_tests ()
    
    Change-Id: I3ddc025b07c47b17ea75554d5cc809a839365f10
    BUG: 1258714
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/12070
    Reviewed-by: Raghavendra Talur <rtalur>
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>

Comment 3 Atin Mukherjee 2015-10-09 17:07:12 UTC
http://review.gluster.org/12329 posted for review to remove the test from bad test

Comment 4 Vijay Bellur 2015-10-12 06:45:07 UTC
REVIEW: http://review.gluster.org/12329 (tests: spurious failure fix for bug-948686.t) posted (#2) for review on master by Atin Mukherjee (amukherj)

Comment 5 Vijay Bellur 2015-11-17 04:23:54 UTC
REVIEW: http://review.gluster.org/12329 (tests: spurious failure fix for bug-948686.t) posted (#3) for review on master by Atin Mukherjee (amukherj)

Comment 6 Vijay Bellur 2015-11-17 14:36:21 UTC
COMMIT: http://review.gluster.org/12329 committed in master by Jeff Darcy (jdarcy) 
------
commit 0f35b301fcb539dd85a1dae202b3ce532852d4d6
Author: Atin Mukherjee <amukherj>
Date:   Fri Oct 9 22:31:28 2015 +0530

    tests: spurious failure fix for bug-948686.t
    
    Ensured import volume and volume start doesn't race in volinfo by refcounting
    volinfo.
    
    Change-Id: I7467eccaba9a00fd63ba0121d8157df24d1c00a6
    BUG: 1258714
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/12329
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 7 Raghavendra Talur 2016-03-08 20:13:27 UTC
"tests" component is for tests framework only.
File a bug under test component if you find a bug in 
1. any of the *.rc files under tests/ 
2. run-tests.sh


For everything else, the bug should be filed on
1. component which is being tested by .t file if the .t file requires fix.
2. component which is causing a valid .t file to fail in regression.

I have used my best judgement here to move the bug to right component.
In case of ambiguity, I have placed the blame on the .t file component.

Please consider test bugs under the same backlog list that tracks other bugs in your component.

Comment 8 Niels de Vos 2016-06-16 13:34:27 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.