Description of problem: A single copy paste error could result in destroying the entire overcloud. There needs to be some warning to ensure that the command wasn't entered in error, and that the user is aware of the consequences. Version-Release number of selected component (if applicable): OSP 7 How reproducible: [stack@undercloud ~]$ heat stack-list +--------------------------------------+------------+-----------------+----------------------+ | id | stack_name | stack_status | creation_time | +--------------------------------------+------------+-----------------+----------------------+ | 0cbb64e3-9f6c-4f89-b19b-f6b169f886ba | overcloud | UPDATE_COMPLETE | 2015-09-03T14:39:33Z | +--------------------------------------+------------+-----------------+----------------------+ [stack@undercloud ~]$ [stack@undercloud ~]$ heat stack-delete overcloud +--------------------------------------+------------+--------------------+----------------------+ | id | stack_name | stack_status | creation_time | +--------------------------------------+------------+--------------------+----------------------+ | 0cbb64e3-9f6c-4f89-b19b-f6b169f886ba | overcloud | DELETE_IN_PROGRESS | 2015-09-03T14:39:33Z | +--------------------------------------+------------+--------------------+----------------------+ [stack@undercloud ~]$ [stack@undercloud ~]$ heat stack-list +----+------------+--------------+---------------+ | id | stack_name | stack_status | creation_time | +----+------------+--------------+---------------+ +----+------------+--------------+---------------+ Steps to Reproduce: 1. Access director server as stack user and source the stackrc file 2. type 'heat stack-delete <STACK NAME>' Actual results: No warning or prompt given prior to stack deletion Expected results: User should be given a prompt with a warning that the action will immediately and irreversibly delete all the nodes associated with the stack and require they type Y or N. Additional info:
This probably would have been a good idea to have baked in from the start. However, there's no way to add it now without breaking any and all existing scripts that include a stack delete.
we could do tty detection so that scripts are unaffected but interactive stack deletes get a prompt
Good idea.
*** Bug 1288473 has been marked as a duplicate of this bug. ***
Upstream patch is ready to merge, just need the +1's.
Upstream has release python-heatclient-1.0.0, which now needs to be packaged.
Lon, python-heatclient-1.0.0 has just been released upstream. Other than being the first stable release of heatclient, it also has added a full suite of heat commands for the python-openstackclient cli. For packaging this means that python-heatclient needs to depend on python-openstackclient. My question is would it be worth packaging python-heatclient-1.0.0 into RHOS 8.0? The benefits to our customers would be access to the new openstack commands, and the UX effort we put into them.
Crag, Steve, was the patch merged, is it part of python-heatclient-1.0.0, is it part of OSP8? Thanks -- Jarda
Yes, this change is in heatclient-1.0.0 and won't be in OSP8 unless it is backported.
*** Bug 1318716 has been marked as a duplicate of this bug. ***
This should be part of Mitaka code already. Closing this for OSP9, earlier versions are handled with separate bugs.
Reopening, closed nextrelease is not valid, this should get tested and closed when we ship OSP9
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHEA-2016-1597.html