Bug 1260185 - Data Tiering:Regression:Commit of detach tier passes without directly without even issuing a detach tier start
Data Tiering:Regression:Commit of detach tier passes without directly without...
Product: GlusterFS
Classification: Community
Component: tiering (Show other bugs)
Unspecified Unspecified
urgent Severity urgent
: ---
: ---
Assigned To: Satish Mohan
Depends On:
Blocks: 1260923
  Show dependency treegraph
Reported: 2015-09-04 12:40 EDT by Gaurav Kumar Garg
Modified: 2016-06-16 09:35 EDT (History)
4 users (show)

See Also:
Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1259694
Last Closed: 2016-06-16 09:35:09 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Gaurav Kumar Garg 2015-09-04 12:40:26 EDT
+++ This bug was initially created as a clone of Bug #1259694 +++

Description of problem:
Detach tier commit should not pass if there was no detach tier start triggered.
That should work only if force option is used clearly.
However, detach tier commit is passing even without detach tier start is triggered, which was not the case previously.
This is a regression.

[root@nag-manual-node1 /]# gluster v info vvs;gluster v status vvs
Volume Name: vvs
Type: Tier
Volume ID: 988d395c-be78-4d84-939b-eaad367f3504
Status: Started
Number of Bricks: 6
Transport-type: tcp
Hot Tier :
Hot Tier Type : Distribute
Number of Bricks: 2
Cold Tier:
Cold Tier Type : Distribute
Number of Bricks: 4
Options Reconfigured:
performance.readdir-ahead: on
Status of volume: vvs
Gluster process                             TCP Port  RDMA Port  Online  Pid
Hot Bricks:
Brick          49156     0          Y       15202
Brick          49156     0          Y       24052
Cold Bricks:
Brick           49152     0          Y       23722
Brick           49152     0          Y       14985
Brick           49153     0          Y       23740
Brick           49153     0          Y       15003
NFS Server on localhost                     2049      0          Y       24071
NFS Server on                   2049      0          Y       15221
Task Status of Volume vvs
Task                 : Rebalance           
ID                   : 034a03d3-f977-4a59-9c55-4a7d9cd429e8
Status               : in progress         
[root@nag-manual-node1 /]# gluster v detach-tier vvs commit
volume detach-tier commit: success
Check the detached bricks to ensure all files are migrated.
If files with data are found on the brick path, copy them via a gluster mount point before re-purposing the removed brick. 
[root@nag-manual-node1 /]# gluster v info vvs
Volume Name: vvs
Type: Distribute
Volume ID: 988d395c-be78-4d84-939b-eaad367f3504
Status: Started
Number of Bricks: 4
Transport-type: tcp
Options Reconfigured:
performance.readdir-ahead: on
[root@nag-manual-node1 /]# 

Version-Release number of selected component (if applicable):
[root@nag-manual-node1 /]# rpm -qa|grep gluster
[root@nag-manual-node1 /]# gluster --version
glusterfs 3.7.4 built on Sep  2 2015 18:06:07
Repository revision: git://git.gluster.com/glusterfs.git
Copyright (c) 2006-2011 Gluster Inc. <http://www.gluster.com>
You may redistribute copies of GlusterFS under the terms of the GNU General Public License.

How reproducible:
everytime easily

Steps to Reproduce:
1.create a volume, start it and attac tier to vol 
2.now issue a detach-tier <vname> commit 

Actual results:
commit detaches tier without even requiring a detach tier start

Expected results:
commit should be allowed only after detach tier start is triggered

It was working previously. hence  a regression
Comment 1 Vijay Bellur 2015-09-04 13:20:03 EDT
REVIEW: http://review.gluster.org/12107 (glusterd: Do not allow "detach-tier commit" unnecessarily) posted (#2) for review on master by Gaurav Kumar Garg (ggarg@redhat.com)
Comment 2 Vijay Bellur 2015-09-08 00:45:32 EDT
COMMIT: http://review.gluster.org/12107 committed in master by Atin Mukherjee (amukherj@redhat.com) 
commit 9efce73fb31d520706a6d47de4daa4fb3366e6a6
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date:   Fri Sep 4 22:10:55 2015 +0530

    glusterd: Do not allow "detach-tier commit" unnecessarily
    Currently when user execute gluster v detach-tier commit command without
    starting detach-tier or without giving force option then gluster will
    success this operation.
    Detach-tier commit should not allow without giving "force" optioin.
    Change-Id: Id161c288f6f3e0f6b298878a5c35a49fcbd9c6e3
    BUG: 1260185
    Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
    Reviewed-on: http://review.gluster.org/12107
    Tested-by: NetBSD Build System <jenkins@build.gluster.org>
    Tested-by: Gluster Build System <jenkins@build.gluster.com>
    Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
    Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Comment 5 Niels de Vos 2016-06-16 09:35:09 EDT
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Note You need to log in before you can comment on or make changes to this bug.