Description of problem: Sharding xattrs are exposed on the mountpoint. It is also possible for the application to tamper with these values from the mountpoint. This should be disallowed. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
REVIEW: http://review.gluster.org/12121 (features/shard: Filter internal shard xattrs in {get,remove,set}xattr) posted (#1) for review on master by Krutika Dhananjay (kdhananj)
REVIEW: http://review.gluster.org/12121 (features/shard: Filter internal shard xattrs in {get,remove,set}xattr) posted (#2) for review on master by Krutika Dhananjay (kdhananj)
REVIEW: http://review.gluster.org/12121 (features/shard: Filter internal shard xattrs in {get,remove,set}xattr) posted (#3) for review on master by Krutika Dhananjay (kdhananj)
REVIEW: http://review.gluster.org/12121 (features/shard: Filter internal shard xattrs in {get,remove,set}xattr) posted (#4) for review on master by Pranith Kumar Karampuri (pkarampu)
COMMIT: http://review.gluster.org/12121 committed in master by Pranith Kumar Karampuri (pkarampu) ------ commit ccb52e0cba557a792b9227c86155a2dc8e29f44f Author: Krutika Dhananjay <kdhananj> Date: Tue Sep 8 08:22:23 2015 +0530 features/shard: Filter internal shard xattrs in {get,remove,set}xattr Change-Id: I40e4a5dbd13d6c3d777e7e01f93dabc83e52b137 BUG: 1260637 Signed-off-by: Krutika Dhananjay <kdhananj> Reviewed-on: http://review.gluster.org/12121 Reviewed-by: Pranith Kumar Karampuri <pkarampu> Tested-by: NetBSD Build System <jenkins.org>
REVIEW: http://review.gluster.org/12136 (features/shard: Add appropriate NULL checks to prevent excessive logging) posted (#1) for review on master by Krutika Dhananjay (kdhananj)
REVIEW: http://review.gluster.org/12136 (features/shard: Add appropriate NULL checks to prevent excessive logging) posted (#2) for review on master by Krutika Dhananjay (kdhananj)
REVIEW: http://review.gluster.org/12136 (features/shard: Add appropriate NULL checks to prevent excessive logging) posted (#3) for review on master by Krutika Dhananjay (kdhananj)
COMMIT: http://review.gluster.org/12136 committed in master by Pranith Kumar Karampuri (pkarampu) ------ commit 605e47fe69a7e11f09f95699348dfab4bbab03ff Author: Krutika Dhananjay <kdhananj> Date: Wed Sep 9 08:34:08 2015 +0530 features/shard: Add appropriate NULL checks to prevent excessive logging Also, 1) the getxattr() callback must check for the fop return status before attempting to delete the internal keys. 2) the correct dict was not being used in shard_getxattr_cbk(). This patch also fixes that issue. Change-Id: I516a1d98e112b572bcec7d1f1e03e23152567be3 BUG: 1260637 Signed-off-by: Krutika Dhananjay <kdhananj> Reviewed-on: http://review.gluster.org/12136 Tested-by: NetBSD Build System <jenkins.org> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Pranith Kumar Karampuri <pkarampu>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user