Bug 1263785 - Remove constants duplication in ovirt-engine-dwh and ovirt-engine-setup
Remove constants duplication in ovirt-engine-dwh and ovirt-engine-setup
Status: VERIFIED
Product: ovirt-engine-dwh
Classification: oVirt
Component: Setup (Show other bugs)
4.2.0
Unspecified Unspecified
low Severity medium (vote)
: ovirt-4.2.0
: 4.2.0
Assigned To: Ido Rosenzwig
Gonza
: CodeChange, Reopened
: 1363824 (view as bug list)
Depends On:
Blocks: 1475130
  Show dependency treegraph
 
Reported: 2015-09-16 13:03 EDT by Rafael Martins
Modified: 2017-09-11 06:35 EDT (History)
11 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-02-01 09:36:35 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: Integration
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rule-engine: ovirt‑4.2+
rule-engine: planning_ack+
sbonazzo: devel_ack+
pstehlik: testing_ack+


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
oVirt gerrit 62917 master NEW setup: plugins: add constant duplication check 2016-10-06 09:51 EDT
oVirt gerrit 64489 master MERGED spec: move engine/constants.py to engine-common package 2016-10-10 03:39 EDT
oVirt gerrit 64916 master NEW packaging: setup: Remove constants duplication 2016-10-09 03:06 EDT
oVirt gerrit 65129 master MERGED packaging: setup: Remove constants duplication 2016-10-10 04:34 EDT
oVirt gerrit 65180 None None None 2016-10-06 11:15 EDT
oVirt gerrit 65409 master MERGED packaging: setup: fix constants deduplication for dev-env 2016-10-13 02:43 EDT
oVirt gerrit 65567 master NEW spec: correctly move engine/constants.py to engine-common package 2016-10-28 06:21 EDT
oVirt gerrit 73339 master ABANDONED packaging: setup: Remove dwh_shared_constants 2017-03-20 03:36 EDT
oVirt gerrit 73841 master MERGED packaging: setup: Move dwh-plugins from engine to dwh 2017-03-20 03:35 EDT
oVirt gerrit 73842 master MERGED packaging: setup: Move dwh-plugins from engine to dwh 2017-03-20 09:51 EDT

  None (edit)
Description Rafael Martins 2015-09-16 13:03:35 EDT
ovirt-engine-dwh and ovirt-engine-setup have some constants duplicated on its codebases. Need to find a way to centralize these constants.

Suggestion from didi: create a new ovirt-engine-dwh-setup-common or similar, with all the duplicated stuff.
Comment 1 Pavel Stehlik 2015-10-15 07:51:39 EDT
Proposing CodeChange, thus QE just sanity.
Comment 2 Red Hat Bugzilla Rules Engine 2015-10-19 07:00:09 EDT
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 3 Yedidyah Bar David 2015-12-27 08:50:01 EST
Simone, IIRC you were for keeping these duplicated. What do you think?
Comment 4 Simone Tiraboschi 2016-03-22 10:52:11 EDT
If everything depends on engine_common or if we have no side effects requiring it everywhere we can just move there.
Comment 6 Sandro Bonazzola 2016-12-02 04:01:26 EST
Update on this bug status?
Comment 7 Ido Rosenzwig 2016-12-07 01:33:37 EST
All patches have been merged.

For some reason the status of several patches still 'NEW' but should be 'MERGED'
Comment 8 Ido Rosenzwig 2016-12-08 08:43:12 EST
The projects that changed are:
 - ovirt-engine
 - ovirt-dwh
 - ovirt-imageio

For testing, please check if all the products are installed correctly and nothing is broken.
Comment 9 Ido Rosenzwig 2016-12-29 05:08:13 EST
*** Bug 1363824 has been marked as a duplicate of this bug. ***
Comment 10 Lukas Svaty 2017-01-31 06:44:41 EST
verified in rhevm-4.1.0.2-0.1.el7.noarch
Comment 11 Yedidyah Bar David 2017-02-08 11:06:53 EST
Reopening. I wasn't aware of [1], which reverts much of the changes for this bug.

We are still affected by it in real life. E.g. patchset 28 of [2] failed, and to prevent the failure I pushed patchset 30, and also [3] for a "proper fix". The intent of current bug was that patches such as [3] would not be needed.

Simone pushed [1] to fix dev-env without dwh. I understand the reasoning and can accept it as a temporary solution, but imo we need a better one on the long term - e.g. make dwh setup mandatory in dev-env, or somehow patch the engine to not fail if it's missing (no idea how much work this will require, the change between 28 and 30 in [2] wasn't hard).

[1] https://gerrit.ovirt.org/65409
[2] https://gerrit.ovirt.org/70422
[3] https://gerrit.ovirt.org/71889
Comment 12 Red Hat Bugzilla Rules Engine 2017-02-08 11:07:08 EST
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 13 Sandro Bonazzola 2017-02-10 03:00:47 EST
Didi, can you fix this?
Comment 14 Yedidyah Bar David 2017-06-28 08:29:25 EDT
Now got a report that makes me think current bug is still not solved, bug 1465859.

It seems like one of the patches removed [1] websocket-proxy's copy of ENGINE_FQDN, and that the engine's copy [2] wasn't changed to have its attributes.

(The fact that they were different at the time is actually current bug).

[1] https://gerrit.ovirt.org/#/c/65129/9/packaging/setup/ovirt_engine_setup/websocket_proxy/constants.py
[2] https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=packaging/setup/ovirt_engine_setup/engine/constants.py;h=bdaee6092954995e86b523c2a8bbf2eee62ec6ff;hb=221c7edba2e615fdd8a7076d5f736d8bde4a6155#l682
Comment 15 Sandro Bonazzola 2017-06-28 08:39:54 EDT
Ido should be back in 1 week, Ido please have a look.
Comment 16 Ido Rosenzwig 2017-07-16 08:20:45 EDT
Working on it.
Comment 17 Sandro Bonazzola 2017-07-19 02:57:15 EDT
Movinf back to assigned as per comment #16
Comment 18 Ido Rosenzwig 2017-07-19 03:34:35 EDT
The additional issue that is mentioned on comment 14 is being tracked on [1].

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1465859

moving back to 'ON_QA'
Comment 19 Gonza 2017-09-11 06:35:03 EDT
Verified with:
ovirt-engine-4.2.0-0.0.master.20170907100709.git14accac.el7.centos.noarch
ovirt-engine-setup-4.2.0-0.0.master.20170907100709.git14accac.el7.centos.noarch
ovirt-engine-dwh-setup-4.2.1-0.0.master.20170906061716.el7.centos.noarch
ovirt-imageio-common-1.1.0-1.el7.noarch

Note You need to log in before you can comment on or make changes to this bug.