Spec URL: http://michael.cronenworth.com/RPMS/php-wikimedia-ip-set.spec SRPM URL: http://michael.cronenworth.com/RPMS/php-wikimedia-ip-set-0-0.1.20150917git.fc22.src.rpm Description: IPSet is a PHP library to match IPs against CIDR specs. Fedora Account System Username: mooninite
According to packagist and github releases, version 1.0.1 = rev 3c2dd6706546fe616e6ceba02044e64dce4fc9be
can you take this for me https://bugzilla.redhat.com/show_bug.cgi?id=1241447 ?
gil's scratch build of php-wikimedia-ip-set-0-0.1.20150917git.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11296241
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines NOTE: manual review ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)". Detailed output of licensecheck in /home/gil/1264209-php-wikimedia-ip-set/review-php-wikimedia-ip- set/licensecheck.txt [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Spec file according to URL is the same as in SRPM. PHP: [x]: Run phpci static analyze on all php files. Note: phpCompatInfo version 4.4.0 DB built Jul 20 2015 15:06:38 CEST static analyze results in /home/gil/1264209-php-wikimedia-ip-set /review-php-wikimedia-ip-set/phpci.log Installation errors ------------------- INFO: mock.py version 1.2.13 starting (python version = 3.4.2)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled ccache Mock Version: 1.2.13 INFO: Mock Version: 1.2.13 Finish: chroot init INFO: installing package(s): /home/gil/1264209-php-wikimedia-ip-set/php-wikimedia-ip-set-0-0.1.20150917git.fc24.noarch.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-i386/root/ --releasever 24 install /home/gil/1264209-php-wikimedia-ip-set/php-wikimedia-ip-set-0-0.1.20150917git.fc24.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: php-wikimedia-ip-set-0-0.1.20150917git.fc24.noarch.rpm php-wikimedia-ip-set-0-0.1.20150917git.fc24.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- php-wikimedia-ip-set (rpmlib, GLIBC filtered): php(language) php-ctype php-spl Provides -------- php-wikimedia-ip-set: php-composer(wikimedia/ip-set) php-wikimedia-ip-set Source checksums ---------------- http://git.wikimedia.org/zip/?r=IPSet.git&format=xz&h=3c2dd6706546fe616e6ceba02044e64dce4fc9be#/php-wikimedia-ip-set-0.tar.xz : CHECKSUM(SHA256) this package : 2eeba6bcad3fc65347dab72637607cd45f9ec99a883e867a46f7834c585340ce CHECKSUM(SHA256) upstream package : 2eeba6bcad3fc65347dab72637607cd45f9ec99a883e867a46f7834c585340ce Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/bin/fedora-review -vpn php-wikimedia-ip-set -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
approved
NOTE: "Buildarch: noarch" should be "BuildArch: noarch"
Thanks. New Package SCM Request ======================= Package Name: php-wikimedia-ip-set Short Description: Library to match IP addresses against CIDR specifications Upstream URL: http://www.mediawiki.org/wiki/IPSet Owners: mooninite Branches: f23 f22 InitialCC:
This SCM request method has been deprecated. Please see https://fedoraproject.org/wiki/PackageDB_admin_requests.
php-wikimedia-ip-set-0-0.1.20150917git.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-151353fbfb
php-wikimedia-ip-set-0-0.1.20150917git.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-7b5fa65d3b
php-wikimedia-ip-set-0-0.1.20150917git.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update php-wikimedia-ip-set' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-151353fbfb
php-wikimedia-ip-set-0-0.1.20150917git.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update php-wikimedia-ip-set' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-7b5fa65d3b
php-wikimedia-ip-set-0-0.1.20150917git.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
php-wikimedia-ip-set-0-0.1.20150917git.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.