Bug 1265638 - AMQP credentials validation broken for Openstack Infra and Cloud providers
Summary: AMQP credentials validation broken for Openstack Infra and Cloud providers
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.4.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.6.0
Assignee: Ladislav Smola
QA Contact: Shveta
URL:
Whiteboard: provider:openstack
Depends On:
Blocks: 1289740
TreeView+ depends on / blocked
 
Reported: 2015-09-23 12:05 UTC by Marius Cornea
Modified: 2016-06-29 14:59 UTC (History)
8 users (show)

Fixed In Version: 5.6.0.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1289740 (view as bug list)
Environment:
Last Closed: 2016-06-29 14:59:48 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1348 0 normal SHIPPED_LIVE CFME 5.6.0 bug fixes and enhancement update 2016-06-29 18:50:04 UTC

Description Marius Cornea 2015-09-23 12:05:23 UTC
Description of problem:
AMQP credentials validation is always successful in the UI for the Openstack cloud and infra providers. 
The log shows that validation failed but the UI shows credentials have been successfully validated:

MIQ(OpenstackQpidEventMonitor.test_connection) Failed testing qpid amqp connection for 192.0.2.1.  The Openstack AMQP service may be using a different provider.  Enable debug logging to see connection exception.


Version-Release number of selected component (if applicable):
5.4.2

How reproducible:
100%

Steps to Reproduce:
1. Add Openstack cloud or infra provider
2. Add any user and password in the amqp credentials box
3. Click validate

Actual results:
Validation successful.

Expected results:
Validation fails.

Additional info:

Comment 3 Greg Blomquist 2015-12-08 15:13:05 UTC
Ladas, can you take a look at this?

Comment 4 Ladislav Smola 2015-12-08 16:18:31 UTC
https://github.com/ManageIQ/manageiq/pull/5753

Comment 5 CFME Bot 2015-12-08 22:20:41 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/2c58e6fc400f8de7eae5cbd824059c3cd7a5c847

commit 2c58e6fc400f8de7eae5cbd824059c3cd7a5c847
Author:     Ladislav Smola <lsmola>
AuthorDate: Tue Dec 8 17:13:20 2015 +0100
Commit:     Ladislav Smola <lsmola>
CommitDate: Tue Dec 8 17:13:20 2015 +0100

    AMQP validation always returned true
    
    AMQP validation always returned true.
    
    Fixes BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1265638

 app/models/manageiq/providers/openstack/manager_mixin.rb | 1 -
 gems/pending/openstack/openstack_event_monitor.rb        | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

Comment 6 CFME Bot 2016-01-12 13:04:37 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=03c42e2337f9555486b392bbc8c52a43e3527e12

commit 03c42e2337f9555486b392bbc8c52a43e3527e12
Author:     Ladislav Smola <lsmola>
AuthorDate: Tue Dec 8 17:13:20 2015 +0100
Commit:     Ladislav Smola <lsmola>
CommitDate: Tue Jan 12 12:02:18 2016 +0100

    AMQP validation always returned true
    
    AMQP validation always returned true.
    
    Fixes BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1265638

 app/models/manageiq/providers/openstack/manager_mixin.rb | 1 -
 gems/pending/openstack/openstack_event_monitor.rb        | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

Comment 7 CFME Bot 2016-01-12 13:04:42 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=f47b7ad8f6a82487775e8bb83d5a8c03d66a9a7d

commit f47b7ad8f6a82487775e8bb83d5a8c03d66a9a7d
Merge: 6d28929 03c42e2
Author:     Greg Blomquist <gblomqui>
AuthorDate: Tue Jan 12 08:03:25 2016 -0500
Commit:     Greg Blomquist <gblomqui>
CommitDate: Tue Jan 12 08:03:25 2016 -0500

    Merge branch 'bz1289740' into '5.5.z'
    
    AMQP validation always returned true
    
    AMQP validation always returned true.
    
    Fixes BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1265638
    
    Clean cherry-pick of:
    https://github.com/ManageIQ/manageiq/pull/5753
    
    5.5.z BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1289740
    
    See merge request !707

 app/models/manageiq/providers/openstack/manager_mixin.rb | 1 -
 gems/pending/openstack/openstack_event_monitor.rb        | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

Comment 8 Shveta 2016-06-01 05:18:49 UTC
AMQP validation works.
Verified in 5.6.0.8-rc1.20160524155303_f2a5a50

Comment 10 errata-xmlrpc 2016-06-29 14:59:48 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348


Note You need to log in before you can comment on or make changes to this bug.