Bug 1268698 - Review Request: rubygem-guard-bundler - Guard gem for Bundler
Review Request: rubygem-guard-bundler - Guard gem for Bundler
Status: NEW
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On: 1516328
Blocks:
  Show dependency treegraph
 
Reported: 2015-10-04 16:31 EDT by Ilya Gradina
Modified: 2017-12-13 09:41 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Ilya Gradina 2015-10-04 16:31:10 EDT
Spec URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-bundler.spec
SRPM URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-bundler-2.1.0-1.fc24.src.rpm
Description: Guard::Bundler automatically install/update your gem bundle when needed.
Fedora Account System Username: ilgrad
Comment 1 Jaroslav Prokop 2017-12-06 12:42:48 EST
Hi Ilya, I did informal review on your package and I found following:

* Group is not needed
  - Group tags are not needed currently, so you should delete lines:
~~~
Group: Development/Languages
~~~

~~~
Group: Documentation
~~~

* Tests are not working
  - Tests are not working properly, because it seems upstream didn't include spec      
    folder in the gem. Please fix this.

* Include Runtime Dependencies
  - With tests I discovered there are runtime dependencies that need to be added.
    Please do so.

I did not discover other errors.
Comment 2 Robert-André Mauchin 2017-12-06 14:27:28 EST
Also grab the license from upstream:

https://raw.githubusercontent.com/guard/guard-bundler/master/LICENSE
Comment 3 Robert-André Mauchin 2017-12-06 14:36:15 EST
Missing runtime deps:


Runtime Dependencies (3):
bundler ~> 1.0
guard ~> 2.2 → not packaged
guard-compat ~> 1.1 → not packaged
Comment 4 Ilya Gradina 2017-12-06 16:57:03 EST
(In reply to Robert-André Mauchin from comment #2)
> Also grab the license from upstream:
> 
> https://raw.githubusercontent.com/guard/guard-bundler/master/LICENSE

the license is already present
Comment 6 Vít Ondruch 2017-12-13 09:41:42 EST
* Remove Coveralls dependecy
  - We don't care about code coverage, so Coveralls pulls in just more
    unnecessary dependencies. Please remove the dependency. This might be the
    medicine:

    ~~~
    # We don't care about code coverage.
    sed -i '/[cC]overalls/ s/^/#/' spec/spec_helper.rb
    ~~~

* Remove the rubygem(guard) dependnecy.
  - Is this dependency required? So far, I have not installed the package and it
    does not look to be required.

* Make sure the test suite is working.
  - It seems that spec_helper library needs to be explicitly loaded to run the
    test suite.
  - It seems that Gemfile is missing to execute some tests. This should help:

     ~~~
     echo "source 'http://rubygems.org'" > Gemfile
     ~~~

  - the "-Ilib" is not required
  - You don't have to delete the test suite after its execution.

Note You need to log in before you can comment on or make changes to this bug.