Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://gitlab.com/jackorp/rubygem-guard-compat/raw/0c4eecca79b92c92086753573328d5255370e400/rubygem-guard-compat.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jackorp/rubygem-guard-compat/fedora-rawhide-x86_64/00678214-rubygem-guard-compat/rubygem-guard-compat-1.2.1-1.fc28.src.rpm Description: Helps creating valid Guard plugins and testing them. Fedora Account System Username: jackorp Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=23300282 This is my first package so please be nice to me.
I'll take it for a review and I can sponsor you as well.
*** Bug 1268695 has been marked as a duplicate of this bug. ***
* Hidden files - rpmlint complains: ~~~ rubygem-guard-compat.noarch: W: hidden-file-or-dir /usr/share/gems/gems/guard-compat-1.2.1/.rubocop_todo.yml ~~~ but it would be probably good idea to get rid of all the hidden file by one sweep, e.g. to replace: ~~~ %exclude %{gem_instdir}/.gitignore %exclude %{gem_instdir}/.rubocop.yml %{gem_instdir}/.rubocop_todo.yml %exclude %{gem_instdir}/.rspec ~~~ by just single line: ~~~ %exclude %{gem_instdir}/.* ~~~ * Missing URL - There is no URL tag in the .spec file. There should probably be some, e.g.: ~~~ URL: https://github.com/guard/guard-compat ~~~ Otherwise the package looks good. Please fix these two nits and I'll approve this package.
Updated spec URL: https://gitlab.com/jackorp/rubygem-guard-compat/raw/fbb428b56066c1490c53750e4c74811bb9aae5b7/rubygem-guard-compat.spec Updated srpm URL: https://copr-be.cloud.fedoraproject.org/results/jackorp/rubygem-guard-compat/fedora-rawhide-x86_64/00681701-rubygem-guard-compat/rubygem-guard-compat-1.2.1-1.fc28.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=23440326
Thx. I can't see any other issue with the package => APPROVED. Please continue with the SCM request, import and build of the package: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Pack age_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-guard-compat