Description of problem: When heketi is run with devices which are already part of a cluster, a new cluster still gets created. Version-Release number of selected component (if applicable): Heketi 1.0.0 Heketi is installed from an upstream build as listed here: https://github.com/heketi/heketi/wiki/Installation How reproducible: Always Steps to Reproduce: 1. Run heketi server 2. Run heketi client to add a node and device[1]: ./heketi-cli load -json=config.json 3. The first run will add the node and device and create a cluster 4. Run it again Actual results: A new cluster is created even when creation of physical volume has failed as the device is already part of a cluster. # ./heketi-cli cluster list Clusters: 58ccca8f5741edd7f0fd2319b6fa1c86 7492058868e171af4d94334177ad7eb2 # ./heketi-cli load -json=jsons/one_node_one_device.json Creating cluster ... ID: e71b984c08c994d445ee6c2400097f88 Creating node rhshdp03.lab.eng.blr.redhat.com ... ID: 9b76b114a87a1b23950d8ae04bcebd11 Adding device /dev/vdb ... # ./heketi-cli cluster list Clusters: 58ccca8f5741edd7f0fd2319b6fa1c86 7492058868e171af4d94334177ad7eb2 e71b984c08c994d445ee6c2400097f88 Server log: [sshexec] ERROR 2015/10/15 15:27:18 /home/lpabon/git/go/src/github.com/heketi/heketi/utils/ssh/ssh.go:155: Failed to run command [sudo pvcreate --dataalignment 256K /dev/vdb] on rhshdp03.lab.eng.blr.redhat.com:22: Err[Process exited with: 5. Reason was: ()]: Stdout []: Stderr [ Can't initialize physical volume "/dev/vdb" of volume group "vg_4bb72f669e4f5106515098dc01e17db4" without -ff Expected results: Cluster creation should fail. Additional info: [1] Config file: { "clusters": [ { "nodes": [ { "node": { "hostnames": { "manage": [ "rhshdp03.lab.eng.blr.redhat.com" ], "storage": [ "rhshdp03.lab.eng.blr.redhat.com" ] }, "zone": 0 }, "devices": [ "/dev/vdb" ] } ] } ] }
Hi Anush, the issue found here is highlighted in the release notes https://github.com/heketi/heketi/releases/tag/1.0.0 as a Known Issue #133. We can keep this bug open to link it to https://github.com/heketi/heketi/issues/133, but it should not affect the release. - Luis
Anush is there a way to 'defer' this bug since it does not apply to Release 1 of Heketi?
(In reply to Luis Pabón from comment #3) > Anush is there a way to 'defer' this bug since it does not apply to Release > 1 of Heketi?
(In reply to Luis Pabón from comment #4) > (In reply to Luis Pabón from comment #3) > > Anush is there a way to 'defer' this bug since it does not apply to Release > > 1 of Heketi? This doesn't have the acks here. So it could remain as is for now?
Solved in 1.4.0. Please move to ON_QA
Solved by https://github.com/heketi/heketi/pull/259
This is a good catch, but this cannot be solved for this release. The fix would be too complicated.
It has been fixed by BZ 1350625, so I guess it wasn't too hard
1.Loaded the topology and the cluster is created successfully for the first time. 2. loaded the topology file again with same hostname and details, No new cluster is created Expected: No new cluster is created sh-4.2# export HEKETI_CLI_SERVER=http://heketi-aplo.cloudapps.myaplo.com sh-4.2# vi topology.json sh-4.2# sh-4.2# heketi-cli topology load --json=topology.json Found node dhcp37-71.lab.eng.blr.redhat.com on cluster 2c553c93babc56ef0f6de385dcabb820 Found device /dev/vdc Found node dhcp37-72.lab.eng.blr.redhat.com on cluster 2c553c93babc56ef0f6de385dcabb820 Found device /dev/vdc Found node dhcp37-191.lab.eng.blr.redhat.com on cluster 2c553c93babc56ef0f6de385dcabb820 Found device /dev/vdc sh-4.2# sh-4.2# heketi-cli cluster list Clusters: 2c553c93babc56ef0f6de385dcabb820 Hence marking it as verified
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-1498.html