Bug 1274930 - Review Request: nodejs-color-namer - Calculate color distance with the Delta-E difference
Summary: Review Request: nodejs-color-namer - Calculate color distance with the Delta-...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Eduardo Mayorga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1275008 1275009
Blocks: 1274934
TreeView+ depends on / blocked
 
Reported: 2015-10-23 23:02 UTC by William Moreno
Modified: 2017-01-27 04:17 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-01-27 04:17:49 UTC
Type: ---
Embargoed:
e: fedora-review?


Attachments (Terms of Use)

Description William Moreno 2015-10-23 23:02:41 UTC
Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/nodejs-color-namer.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/nodejs-color-namer-1.0.0-0.fc24.src.rpm
Description: Calculate color distance with the Delta-E  difference
Fedora Account System Username: williamjmorenor

Test builds: https://copr.fedoraproject.org/coprs/williamjmorenor/fedora-review-test/build/129932/

Comment 1 Eduardo Mayorga 2015-10-24 16:14:46 UTC
Diff spec file in url and in SRPM
---------------------------------
--- /home/mayorga/reviews/1274930-nodejs-color-namer/srpm/nodejs-color-namer.spec	2015-10-24 09:49:38.906554668 -0600
+++ /home/mayorga/reviews/1274930-nodejs-color-namer/srpm-unpacked/nodejs-color-namer.spec	2015-10-23 16:44:04.000000000 -0600
@@ -1,10 +1,10 @@
 Name:               nodejs-color-namer
 Version:            1.0.0
-Release:            1%{?dist}
+Release:            0%{?dist}
 Summary:            Calculate color distance with the Delta-E  difference
 Group:              Development/Libraries
 License:            UNLICENSE
 URL:                https://www.npmjs.com/package/color-namer
-Source0:            http://registry.npmjs.org/color-namer/-/color-namer-%{version}.tgz
+Source0:            http://registry.npmjs.org/color-name/-/color-name-%{version}.tgz
 
 BuildArch:          noarch
@@ -29,5 +29,7 @@
 %install
 mkdir -p %{buildroot}%{nodejs_sitelib}/color-namer
-cp -pr package.json index.js lib/ dist/ \
+cp -pr package.json \
+    %{buildroot}%{nodejs_sitelib}/color-namer
+cp -pr index.json \
     %{buildroot}%{nodejs_sitelib}/color-namer
 
@@ -35,9 +37,7 @@
 
 %files
+%license UNLICENSE
 %doc README.md
 %{nodejs_sitelib}/color-namer/
 
 %changelog
-* Fri Oct 23 2015 William Moreno <williamjmorenor> - 1.0.0-1
-- Initial Packaging
-

Please provide the same Spec in both the Spec URL and the SRPM.

Comment 3 William Moreno 2016-02-26 18:22:01 UTC
Any update?

Comment 4 Eduardo Mayorga 2016-07-09 05:18:40 UTC
Sorry for the delay. Please update to the latest upstream release.


Note You need to log in before you can comment on or make changes to this bug.