Bug 1275009 - Review Request: nodejs-chroma-js - JavaScript library for color conversions
Review Request: nodejs-chroma-js - JavaScript library for color conversions
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Piotr Popieluch
Fedora Extras Quality Assurance
Depends On:
Blocks: nodejs-reviews 1274930
  Show dependency treegraph
Reported: 2015-10-24 16:30 EDT by William Moreno
Modified: 2017-02-18 11:15 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2017-02-18 11:15:34 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
piotr1212: fedora‑review-

Attachments (Terms of Use)

  None (edit)
Description William Moreno 2015-10-24 16:30:52 EDT
Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/nodejs-chroma-js.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/nodejs-chroma-js-1.1.1-1.fc24.src.rpm
Description: JavaScript library for color conversions
Fedora Account System Username: williamjmorenor
Comment 1 Piotr Popieluch 2015-11-14 07:40:20 EST
Thanks for packaging. 

This needs some work before I can approve:

- License: should be BSD, not GPL, it also seems that there are more license files, please check if this is multi-licensed and set correct licenses
- URL: Please set correct url which points to the actual package
- BuildRequires, I expect there are some deps missing, at least grunt-cli
- %prep, use "cp -p" to preserve timestamps
- %build, package needs to be build with "grunt"
- Please add %check section with tests
- %install, nothing is being installed
- %changelog, incorrect version 1.0.0 instead of 1.1.1

If you need help/clarification on some items let me know.
Comment 2 William Moreno 2015-12-28 17:47:15 EST
Thanks for take the review.

I am not sure about how to build the sources with grunt in %%build. Can please provide me a example.
Comment 3 Piotr Popieluch 2016-01-28 05:29:56 EST
Excuse me for the late response

you can build with:

BuildRequires: npm(grunt-cli)
BuildRequires: npm(grunt-contrib-clean)
BuildRequires: npm(grunt-contrib-coffee)
BuildRequires: npm(grunt-replace)
BuildRequires: npm(grunt-contrib-uglify)

%nodejs_symlink_deps --build

Only thing is that dependency grunt-replace is not packaged yet. You will have to package that one first (or just use sed to set the version in chroma.js, and patch out grunt-replace out of the Gruntfile.js).
Comment 4 Piotr Popieluch 2017-02-18 07:52:02 EST
This is a quite old review request, do you still want to package this or can we close this request?
Comment 5 William Moreno 2017-02-18 11:15:34 EST
Not rigth now, thanks for the review.

Note You need to log in before you can comment on or make changes to this bug.