Bug 1276632 - Review Request: geronimo-jcdi-1.1-api - Apache Geronimo JCDI Spec 1.1
Review Request: geronimo-jcdi-1.1-api - Apache Geronimo JCDI Spec 1.1
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jonny Heggheim
Fedora Extras Quality Assurance
Depends On:
Blocks: 1306675
  Show dependency treegraph
Reported: 2015-10-30 06:35 EDT by gil cattaneo
Modified: 2016-11-16 17:00 EST (History)
2 users (show)

See Also:
Fixed In Version: geronimo-jcdi-1.1-api-1.0-1.fc26
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2016-11-14 11:47:34 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
hegjon: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description gil cattaneo 2015-10-30 06:35:43 EDT
Spec URL: https://gil.fedorapeople.org/geronimo-jcdi-1.1-api.spec
SRPM URL: https://gil.fedorapeople.org/geronimo-jcdi-1.1-api-1.0-1.fc22.src.rpm
Apache Geronimo implementation of the JSR-346 Context and
Dependency Injection 1.1, 1.2 Specification
Fedora Account System Username: gil

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=11638674
Comment 2 Upstream Release Monitoring 2015-11-06 09:43:10 EST
gil's scratch build of geronimo-jcdi-1.1-api-1.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11727247
Comment 3 Jonny Heggheim 2016-11-13 18:17:21 EST
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache (v2.0)". 2 files
     have unknown license. Detailed output of licensecheck in
[x]: License file installed when any subpackage combination is installed.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
I assume that it does not conflict with geronimo-jcdi-1.0-api that you also maintain.

[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It
     is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

[x]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Checking: geronimo-jcdi-1.1-api-1.0-1.fc26.noarch.rpm
geronimo-jcdi-1.1-api.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Rpmlint (installed packages)
geronimo-jcdi-1.1-api.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

geronimo-jcdi-1.1-api (rpmlib, GLIBC filtered):

geronimo-jcdi-1.1-api-javadoc (rpmlib, GLIBC filtered):



Source checksums
http://repo2.maven.org/maven2/org/apache/geronimo/specs/geronimo-jcdi_1.1_spec/1.0/geronimo-jcdi_1.1_spec-1.0-source-release.zip :
  CHECKSUM(SHA256) this package     : f768a22fd9e148d4fa27b581692a95a889d173f6d95af8ddd4fde5bfa0bd0ad3
  CHECKSUM(SHA256) upstream package : f768a22fd9e148d4fa27b581692a95a889d173f6d95af8ddd4fde5bfa0bd0ad3

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1276632
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Comment 4 Jonny Heggheim 2016-11-13 18:17:45 EST
Review approved!
Comment 5 gil cattaneo 2016-11-13 18:23:39 EST
Thanks for the review!

create new SCM requests:
Comment 6 Gwyn Ciesla 2016-11-14 10:39:50 EST
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/geronimo-jcdi-1.1-api
Comment 7 gil cattaneo 2016-11-14 11:47:34 EST
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16450476
Comment 8 Jonny Heggheim 2016-11-16 16:34:29 EST
Can you review bug 1395867 ?
Comment 9 gil cattaneo 2016-11-16 16:43:57 EST
(In reply to Jonny Heggheim from comment #8)
> Can you review bug 1395867 ?

Sure, i'm starting now
Comment 10 Jonny Heggheim 2016-11-16 17:00:56 EST
(In reply to gil cattaneo from comment #9)
> Sure, i'm starting now


Note You need to log in before you can comment on or make changes to this bug.