Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1276652

Summary: Wildcard patterns in command arguments not expanded
Product: Red Hat Enterprise Linux 6 Reporter: Martin Frodl <mfrodl>
Component: sosAssignee: Shane Bradley <sbradley>
Status: CLOSED ERRATA QA Contact: Martin Frodl <mfrodl>
Severity: unspecified Docs Contact:
Priority: high    
Version: 6.7CC: agk, bmr, bnater, dkutalek, gavin, mhradile, plambri, pmoravec, salmy, sbradley
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: sos-3.2-38.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1276660 (view as bug list) Environment:
Last Closed: 2016-05-10 21:07:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1274384    

Description Martin Frodl 2015-10-30 11:30:08 UTC 
Description of problem:

Some plugins collect the output of commands with paths containing a wildcard expression in their arguments. These wildcards are never expanded.

For instance, ipa plugin collects the output of the following command:

    ls -la /etc/dirsrv/slapd-*/schema

Having created a sample directory matching this pattern, the actual output of the ls command is:

# ls -la /etc/dirsrv/slapd-*/schema/
total 8
drwxr-xr-x. 2 root root 4096 Oct 30 07:07 .
drwxr-xr-x. 3 root root 4096 Oct 30 07:07 ..

What sosreport collects, however, looks like this:

# cat sosreport-blabla/sos_commands/ipa/ls_-la_.etc.dirsrv.slapd-_.schema
ls: cannot access /etc/dirsrv/slapd-*/schema/: No such file or directory

There are other plugins affected by this bug, so far I know about md and smartcard.

This bug was not present sos-2.2-68.el6.noarch.

Version-Release number of selected component (if applicable):
sos-3.2-28.el6.noarch
Comment 3 Pavel Moravec 2016-01-13 09:54:03 UTC 
Reproduced outside sos:

import os
from subprocess import Popen, PIPE, STDOUT

args = ['timeout', '300s', 'ls', '-la', '/etc/dirsrv/slapd-*/schema/']

def _child_prep_fn():
    os.chroot('/')

p = Popen(args, shell=False, stdout=PIPE,
          stderr=STDOUT,
          bufsize=-1, env=os.environ, close_fds=True,
          preexec_fn=_child_prep_fn)
stdout, stderr = p.communicate()

print "status: %s, output: %s" %(p.returncode, stdout.decode('utf-8', 'ignore'))


Returns:

status: 2, output: ls: cannot access /etc/dirsrv/slapd-*/schema: No such file or directory
Comment 4 Bryn M. Reeves 2016-01-13 10:41:32 UTC 
It's a regression as we no longer run commands under a shell:

commit 46b6c3d39f923d19fa7fcfec96c1cf2d23c768be
Author: Bryn M. Reeves <bmr>
Date:   Sun Apr 6 18:01:33 2014 +0100

    Call Popen with shell=False
    
    Fixes Issue #253.
    
    Signed-off-by: Bryn M. Reeves <bmr>

I am not inclined to revert this: it protects us from bugs and potential security problems where the shell expands values in unintended ways.

My preference for a fix is to use glob.glob() to expand _only_ glob syntax in the argument list before passing the string to shlex.split().
Comment 16 errata-xmlrpc 2016-05-10 21:07:56 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0819.html