Bug 1277818 - (vowpal-wabbit) Review Request: vowpal-wabbit - Fast and efficient machine learning system
Review Request: vowpal-wabbit - Fast and efficient machine learning system
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Zbigniew Jędrzejewski-Szmek
Fedora Extras Quality Assurance
Depends On:
Blocks: fedora-neuro
  Show dependency treegraph
Reported: 2015-11-04 01:44 EST by Igor Gnatenko
Modified: 2017-03-05 17:31 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
zbyszek: fedora‑review?

Attachments (Terms of Use)

  None (edit)
Description Igor Gnatenko 2015-11-04 01:44:19 EST
Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/vowpal-wabbit.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/vowpal-wabbit-8.1-1.fc24.src.rpm
The Vowpal Wabbit (VW) project is a fast out-of-core learning system sponsored
by Microsoft Research and (previously) Yahoo! Research.
Fedora Account System Username: ignatenkobrain
Comment 2 Zbigniew Jędrzejewski-Szmek 2015-11-26 15:50:58 EST
Please extend the %description to say what this package actually does. Who sponsors the project is something that is not normally included in the %description.

Since you install stuff in %{_libdir}, add scriptlets [https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries].

Version 8.1.1 is out.
Comment 4 Zbigniew Jędrzejewski-Szmek 2015-11-28 21:33:35 EST
/bin/vw-regr uses ruby. It has #!/usr/bin/env ruby in the header, and there are no dependencies on ruby.

/bin/vm-hypersearch has /usr/bin/env perl, it should have /usr/bin/perl.

Are you sure that active_interactor, ezexample_*, library_exmaple, spanning_tree should be installed in /bin? Maybe those examples should go in /usr/share/doc to avoid polluting the $PATH.
Comment 5 Zbigniew Jędrzejewski-Szmek 2017-03-05 17:31:28 EST
What's up with this one?

Note You need to log in before you can comment on or make changes to this bug.