Red Hat Bugzilla – Bug 1279187
Review Request: python-pyoptical - Pure python interface to OptiCAL
Last modified: 2015-12-09 15:51:05 EST
Spec URL: https://alvesadrian.fedorapeople.org/neurofedora/python-pyoptical.spec
SRPM URL: https://alvesadrian.fedorapeople.org/neurofedora/python-pyoptical-0.4-1.fc24.src.rpm
Description: Pure python interface to OptiCAL
Fedora Account System Username: alvesadrian
No need to have both python2 and python3 scripts [https://fedoraproject.org/wiki/Packaging:Python#Executables_in_.2Fusr.2Fbin].
Looks fine otherwise.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> No need to have both python2 and python3 scripts
> Looks fine otherwise.
But those scripts uses different python runtimes. Wiki is not clear for me. Not sure if they provides exactly same functions. Should I make only one unversioned binary and put it to py3 pkg?
Yes, iiuc, the script simply prints values reported by the device to stdout. It should not matter what python runtime is used. If it works with python3, python3 runtime should be used.
New SPEC: https://ignatenkobrain.fedorapeople.org/neurofedora/python-pyoptical.spec
New SRPM: https://ignatenkobrain.fedorapeople.org/neurofedora/python-pyoptical-0.4-2.fc24.src.rpm
- license is OK
- license file is missing, but upstream has been bugged
- latest version
- latest python packaging template is used
- requires/provides are sane
- builds and installs fine
Package is APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-pyoptical
python-pyoptical-0.4-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-e1562fb56d
python-pyoptical-0.4-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-pyoptical'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-e1562fb56d
python-pyoptical-0.4-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.