Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1279548

Summary: [upgrade] broker.conf got overwritten with initial defaults during 3.5 -> 3.6 upgrade
Product: [oVirt] ovirt-hosted-engine-ha Reporter: Simone Tiraboschi <stirabos>
Component: Packaging.rpmAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED CURRENTRELEASE QA Contact: Artyom <alukiano>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 1.3.2.1CC: bmcclain, bugs, didi, gklein, lveyde, mavital, rmartins, sbonazzo, s.danzi, stirabos
Target Milestone: ovirt-3.6.1Keywords: Triaged
Target Release: 1.3.3Flags: rule-engine: ovirt-3.6.z+
bmcclain: planning_ack+
sbonazzo: devel_ack+
istein: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: integration
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-16 12:19:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1284954, 1285700    

Description Simone Tiraboschi 2015-11-09 17:13:24 UTC
Description of problem:
in 3.6 broker.conf got moved to the shared storage and periodically copied to /var/lib/ovirt-hosted-engine-ha/broker.conf for caching purposes and to be able to send notification also when the shared storage goes down; during a 3.5 -> 3.6 upgrade, broker.conf got overwritten with initial defaults


Version-Release number of selected component (if applicable):
1.3.1.2

How reproducible:
100%

Steps to Reproduce:
1. upgrade form 3.5 to 3.6
2. check /var/lib/ovirt-hosted-engine-ha/broker.conf 
3.

Actual results:
broker.conf on the shared storage got written with the initial defaults

Expected results:
broker.conf on the shared storage got written with the values it had just before the upgrade.

Additional info:

Ho to fix the copy on the shared storage if it's already happened:
dir=`mktemp -d` && cd $dir
systemctl stop ovirt-ha-broker
sdUUID_line=$(grep sdUUID /etc/ovirt-hosted-engine/hosted-engine.conf)
sdUUID=${sdUUID_line:7:36}
conf_volume_UUID_line=$(grep conf_volume_UUID /etc/ovirt-hosted-engine/hosted-engine.conf)
conf_volume_UUID=${conf_volume_UUID_line:17:36}
conf_image_UUID_line=$(grep conf_image_UUID /etc/ovirt-hosted-engine/hosted-engine.conf)
conf_image_UUID=${conf_image_UUID_line:16:36}
dd if=/rhev/data-center/mnt/192.168.1.115:_Virtual_ext35u36/$sdUUID/images/$conf_image_UUID/$conf_volume_UUID 2>/dev/null| tar -xvf -
cp /etc/ovirt-hosted-engine-ha/broker.conf.rpmsave broker.conf # or edit broker.conf as you need 
tar -cO * | dd of=/rhev/data-center/mnt/192.168.1.115:_Virtual_ext35u36/$sdUUID/images/$conf_image_UUID/$conf_volume_UUID
systemctl start ovirt-ha-broker

Comment 1 Red Hat Bugzilla Rules Engine 2015-11-09 17:23:29 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 2 Red Hat Bugzilla Rules Engine 2015-11-09 17:23:29 UTC
This bug is not marked for z-stream, yet the milestone is for a z-stream version, therefore the milestone has been reset.
Please set the correct milestone or add the z-stream flag.

Comment 3 Artyom 2015-12-08 13:57:38 UTC
Verified on ovirt-hosted-engine-ha-1.3.3.1-1.el7ev.noarch
After upgrade of packages and restart /var/lib/ovirt-hosted-engine-ha/broker.conf content equal to /etc/ovirt-hosted-engine-ha/broker.conf in 3.5

Comment 4 Sandro Bonazzola 2015-12-16 12:19:06 UTC
According to verification status and target milestone this issue should be fixed in oVirt 3.6.1. Closing current release.