Red Hat Bugzilla – Bug 1279579
Review Request: itktools - Practical command line tools based on the ITK
Last modified: 2016-08-14 11:29:32 EDT
Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/ITKTools.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/ITKTools-0.3.1-0.1.git5a21673.fc24.src.rpm
Practical command line tools based on the ITK, intended for image processing.
These tools are designed to take one or more input image(s) from the command
line, perform a single operation, and produce an output image. For example
smoothing of an image can be done with the tool pxgaussianimagefilter.
Fedora Account System Username: ignatenkobrain
The name should really be lowercase, it's a bother to remember complex capitalization. https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming says "Package names should be in lower case and use dashes in preference to underscores."
You *could* build the documentation, would be nice to have a pdf with the help.
No need to rm -rf build/ in %prep: %autosetup will recreate the whole source directory anyway. This applies also to a few other packages that I reviewed; I forgot to mention it before.
#!/usr/bin/env python3 → #!/usr/bin/python3.
- license is OK (Apache)
- license file is present, %license is used
- latest version
- no scriptlets needed or present
- package builds and installs
Build fails in tests, I'll kick of a scratch build.
Note to self: check explicit Requires: python3.
zbyszek's scratch build of ITKTools-0.3.1-0.1.git5a21673.fc24.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12024667
New SPEC: https://ignatenkobrain.fedorapeople.org/neurofedora/itktools.spec
New SRPM: https://ignatenkobrain.fedorapeople.org/neurofedora/itktools-0.3.1-0.2.git5a21673.fc24.src.rpm
I'm not sure if I did exclude tests properly, but I kicked off scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12082859
ignatenkobrain's scratch build of itktools-0.3.1-0.2.git5a21673.fc24.src.rpm for f24 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12082859
All tests failed on arm due to
26: Test timeout computed to be: 1500
26: terminate called after throwing an instance of 'std::length_error'
26: what(): vector::_M_fill_insert
I see the same problem with DiffusionKurtosisFit
Packaging is OK. Let's hope we can get #1291010 fixed at some point.
Package is APPROVED.
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see email@example.com with any questions