Red Hat Bugzilla – Bug 1282263
[PATCH] python3-openid FTBFS in rawhide
Last modified: 2016-11-30 19:58:16 EST
Created attachment 1094615 [details]
Update to the latest upstream.
python3-openid fails to build from source in rawhide. The issue is an ImportError from of a deprecated stdlib exception.
The issue is fixed in the latest upstream release: https://github.com/necaris/python3-openid/pull/15
I've attached a patch to the spec file here. It would be a simple version update, but the patch originally applied in the spec file broke, so, instead of rebasing it, I removed it and replaced it with a sed statement in the prep section. This should be less fragile in the face of future releases. The patch here also adds some new deps for expanded tests in the check section.
Scratch build with this applied:
Note that I particularly like the "fragileness" of a patch instead of sed.
The reason for that is that that means that whatever patch you have needs to be explicitly rebased when you update, and as such the chance that you leave old, no longer needed, patches in is pretty much non-existent.
That's reasonable, Patrick. I won't rebase my patch with that though but will instead just let the maintainer(s) apply it or change it as they prefer.
It would be fairly easy to add a 'test' before the sed which would fail if no files contained "/usr/bin/env python", and have that cause the build to fail with a message saying 'you can take the sed out now'.
Also, the packager somehow did a 3.0.6 build that worked, so this isn't FTBFS any more.
Hi, I apologize. First I saw that it needs to be rebuilt with Python-3.5, so I checked https://github.com/necaris/python3-openid/ and built 3.0.6 (unfortunately the latest tag in git).
Later I found this bug and realized that there are newer tarballs on https://pypi.python.org/pypi/python3-openid/.
P. S. I've taken the ease of sed and added fragility of diff. §;o)