RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1287301 - fence_compute does not advertise itself correctly
Summary: fence_compute does not advertise itself correctly
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: fence-agents
Version: 7.2
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: rc
: ---
Assignee: Oyvind Albrigtsen
QA Contact: Asaf Hirshberg
URL:
Whiteboard:
Depends On:
Blocks: 1185030 1287303
TreeView+ depends on / blocked
 
Reported: 2015-12-01 22:39 UTC by Andrew Beekhof
Modified: 2016-11-04 04:48 UTC (History)
3 users (show)

Fixed In Version: fence-agents-4.0.11-38.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-04 04:48:41 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:2373 0 normal SHIPPED_LIVE fence-agents bug fix update 2016-11-03 13:51:30 UTC

Description Andrew Beekhof 2015-12-01 22:39:33 UTC
Description of problem:

fence_compute works more like a fabric fencing device than a network power switch.
It should advertise the fabric_fencing and on_target options to avoid the need for ugly work-arounds in pacemaker.

Version-Release number of selected component (if applicable):

fence-agents-all-4.0.11-27.el7.x86_64

How reproducible:

100%

Steps to Reproduce:
1. fence_compute -o metadata

Actual results:

...
<actions>
	<action name="on"/>


Expected results:

...
<actions>
	<action name="on" on_target="1" automatic="1"/>

Additional info:

--- /sbin/fence_compute.orig	2015-11-26 20:09:12.165071987 -0500
+++ /sbin/fence_compute	2015-11-30 21:44:08.176674412 -0500
@@ -187,7 +198,7 @@
 	global nova
 	atexit.register(atexit_handler)
 
-	device_opt = ["login", "passwd", "tenant-name", "auth-url",
+	device_opt = ["login", "passwd", "tenant-name", "auth-url", "fabric_fencing", "on_target",
 		"no_login", "no_password", "port", "domain", "no-shared-storage", "endpoint-type",
 		"record-only"]
 	define_new_opts()

Comment 1 Andrew Beekhof 2015-12-03 02:36:00 UTC
https://github.com/ClusterLabs/fence-agents/pull/33

Comment 3 Asaf Hirshberg 2016-06-16 11:58:42 UTC
Andrew, 

I got the following the expected result from fence-agents4.0.11-27

</resource-agent>
[root@overcloud-controller-2 ~]# fence_compute -o metadata|grep -A3 action
	<parameter name="action" unique="0" required="1">
		<getopt mixed="-o, --action=[action]" />
		<content type="string" default="off"  />
		<shortdesc lang="en">Fencing Action</shortdesc>
	</parameter>
--
<actions>
	<action name="on" on_target="1" automatic="1"/>
	<action name="off" />
	<action name="status" />
	<action name="list" />
	<action name="list-status" />
	<action name="monitor" />
	<action name="metadata" />
</actions>
</resource-agent>

Did I missed something? as it fixed in fence-agents-4.0.11-38.el7

Comment 4 Andrew Beekhof 2016-06-16 23:10:47 UTC
They must have forgotten to close the bug

Comment 5 Oyvind Albrigtsen 2016-06-17 07:03:37 UTC
Correct.

It was already fixed, so I set Resolves for this bz for fence-agents-4.0.11-38.el7, as that was missing from the changelog.

Comment 7 errata-xmlrpc 2016-11-04 04:48:41 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2373.html


Note You need to log in before you can comment on or make changes to this bug.