Bug 1288122 - version update for default cluster fails with NPE
Summary: version update for default cluster fails with NPE
Keywords:
Status: CLOSED DUPLICATE of bug 1261851
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: ---
Assignee: bugs@ovirt.org
QA Contact: Pavel Stehlik
URL:
Whiteboard: virt
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-12-03 15:20 UTC by Piotr Kliczewski
Modified: 2015-12-04 15:53 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-12-04 14:13:21 UTC
oVirt Team: ---
Embargoed:
rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1288116 0 unspecified CLOSED You can't change default cluster to a 3.x compat mode cluster. 2021-02-22 00:41:40 UTC

Internal Links: 1288116

Description Piotr Kliczewski 2015-12-03 15:20:56 UTC 
Description of problem:

When using freshly installed engine with clean db changing cluster version fails with NPE on the backend.

Version-Release number of selected component (if applicable):


How reproducible:
100% reproducible


Steps to Reproduce:
1. Install ovirt-engine (no contents in db)
2. edit DC and change version to 3.5
3. edit cluster and change version to 3.5 (no changes to cpu type, ui do not require it)

Actual results:
engine backend fails with NPE:

2015-12-03 16:05:37,480 ERROR [org.ovirt.engine.core.bll.GetClusterEditWarningsQuery] (default task-29) [] Query 'GetClusterEditWarningsQuery' failed: null
2015-12-03 16:05:37,480 ERROR [org.ovirt.engine.core.bll.GetClusterEditWarningsQuery] (default task-29) [] Exception: java.lang.NullPointerException
	at org.ovirt.engine.core.bll.UnsupportedVmCpuClusterEditChecker.isApplicable(UnsupportedVmCpuClusterEditChecker.java:23) [bll.jar:]
	at org.ovirt.engine.core.bll.UnsupportedVmCpuClusterEditChecker$Proxy$_$$_WeldClientProxy.isApplicable(Unknown Source) [bll.jar:]
	at org.ovirt.engine.core.bll.GetClusterEditWarningsQuery.lambda$getProblematicEntities$42(GetClusterEditWarningsQuery.java:70) [bll.jar:]
	at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174) [rt.jar:1.8.0_65]
	at java.util.Iterator.forEachRemaining(Iterator.java:116) [rt.jar:1.8.0_65]
	at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801) [rt.jar:1.8.0_65]
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481) [rt.jar:1.8.0_65]
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471) [rt.jar:1.8.0_65]
	at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708) [rt.jar:1.8.0_65]


Expected results:
Cluster version updated and no issues in the log.

Additional info:
This issue occurs on 3.6 branch as well.
Comment 1 Einav Cohen 2015-12-04 05:39:25 UTC 
looks like the exception is in the backend -> removing the "[ui]" prefix from the summary (a bit misleading).
Comment 2 Piotr Kliczewski 2015-12-04 13:53:38 UTC 
I still think that it is UI issue. The cpu type is not validated before sending request to the engine.
Comment 3 Oved Ourfali 2015-12-04 14:09:17 UTC 
I think the two bugs are different. 
However, it seems related to bug 1261851.

Micahl, can someone at virt take a look? 
Piotr, this might be fixed by a UI validation, but the engine code should throw npe.
Comment 4 Piotr Kliczewski 2015-12-04 14:13:21 UTC 
I reopened bug 1261851 and marking this as duplicate.

*** This bug has been marked as a duplicate of bug 1261851 ***
Note You need to log in before you can comment on or make changes to this bug.