Spec URL: https://jplesnik.fedorapeople.org/perl-Code-TidyAll/perl-Code-TidyAll.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-Code-TidyAll/perl-Code-TidyAll-0.36-1.fc24.src.rpm Description: This is the engine used by tidyall - read that first to get an overview. You can call this API from your own program instead of executing tidyall. Fedora Account System Username: jplesnik
Well, this one is big and the code fairly unreadable. Apologies for the delay. Anyhow, the provided separate SPEC file is for version 0.37 while the provided SRPM is for 0.36. The differences in upstream code are minimal; I'll be reviewing 0.36 here. Please, don't update the links.
* You list the Test::Class::Most build time dependency twice. * Some of the listed build time dependencies aren't actually necessary, namely: - autodie - IPC::System::Simple - List::Compare - Log::Any - Test::Builder * One build time dependency missing: lib * The package description is fairly poorly written and doesn't say much. * The summary implies this package is just the engine, even though it also installs the utility it refers to. You could keep that and split the utility into a subpackage, if you think it makes sense. Or change the summary. Your call. * Many of the plugins require external utilities you neither require nor recommend/suggest. The package won't work as advertised without them. See the Code::TidyAll::Plugin namespace. * Possibly similar situation with the VCSs -- will this work without git or subversion? Maybe -- I don't know how these hooks are meant to be used.
Files are updated Spec URL: https://jplesnik.fedorapeople.org/perl-Code-TidyAll/perl-Code-TidyAll.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-Code-TidyAll/perl-Code-TidyAll-0.37-1.fc24.src.rpm
* You still list Test::Class::Most twice. * The `lib' dependency is still missing. * I guess the summary and description are a little better now. Alright... * Trailing whitespace on line 53.
Updated files are on the same links.
Okay, I'm going to approve this.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Code-TidyAll