Bug 1288739 - Review Request: petpvc - Tools for partial volume correction (PVC) in positron emission tomography (PET)
Review Request: petpvc - Tools for partial volume correction (PVC) in positro...
Status: POST
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Zbigniew Jędrzejewski-Szmek
Fedora Extras Quality Assurance
:
Depends On: 1291010
Blocks: fedora-neuro
  Show dependency treegraph
 
Reported: 2015-12-05 13:39 EST by Igor Gnatenko
Modified: 2016-08-14 11:27 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
zbyszek: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Igor Gnatenko 2015-12-05 13:39:57 EST
Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/petpvc.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/petpvc-0.0.0-0.1.git775857a.fc24.src.rpm
Description:
Toolbox for partial volume correction (PVC) in positron emission tomography (PET).
Fedora Account System Username: ignatenkobrain
Comment 1 Zbigniew Jędrzejewski-Szmek 2015-12-08 17:23:15 EST
No need to 'rm -rf build', %autosetup recreated the source directory anyway.

Please extend the %description... What is this software actually useful for, what does it do?

Seems to be missing BR: InsightToolkit-devel, gdcm-devel, fftw-devel, vxl-devel.

+ license is OK (ASL 2)
+ license file is present, %license is used
+ name is OK
+ latest version (git snapshot)
+ %check is present, some checks fail
+ builds and installs, binaries run

rpmlint:
petpvc.src: E: summary-too-long C Toolbox for partial volume correction (PVC) in positron emission tomography (PET)
petpvc.src: E: description-line-too-long C Toolbox for partial volume correction (PVC) in positron emission tomography (PET).
petpvc.x86_64: E: summary-too-long C Toolbox for partial volume correction (PVC) in positron emission tomography (PET)
petpvc.x86_64: E: description-line-too-long C Toolbox for partial volume correction (PVC) in positron emission tomography (PET).
Please fix. Maybe "Toolbox for partial volume correction in positron emission tomography"?

petpvc.x86_64: W: no-manual-page-for-binary pvc_rl
petpvc.x86_64: W: no-manual-page-for-binary pvc_mtc
petpvc.x86_64: W: no-manual-page-for-binary petpvc
petpvc.x86_64: W: no-manual-page-for-binary pvc_vc
petpvc.x86_64: W: no-manual-page-for-binary pvc_iy
petpvc.x86_64: W: no-manual-page-for-binary pvc_rbv
petpvc.x86_64: W: no-manual-page-for-binary pvc_mg
petpvc.x86_64: W: no-manual-page-for-binary pvc_diy
petpvc.x86_64: W: no-manual-page-for-binary pvc_gtm
petpvc.x86_64: W: no-manual-page-for-binary pvc_labbe
petpvc.x86_64: W: no-manual-page-for-binary pvc_simulate
3 packages and 0 specfiles checked; 4 errors, 11 warnings.

OK.

Please fix the missing BR and summary and description when importing. Package is APPROVED.
Comment 2 Gwyn Ciesla 2015-12-12 12:28:42 EST
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/petpvc
Comment 3 Mike McCune 2016-03-28 19:47:57 EDT
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune@redhat.com with any questions

Note You need to log in before you can comment on or make changes to this bug.