Bug 1288827 (python-pacpy) - Review Request: python-pacpy - Calculate phase-amplitude coupling in Python
Summary: Review Request: python-pacpy - Calculate phase-amplitude coupling in Python
Keywords:
Status: CLOSED ERRATA
Alias: python-pacpy
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: fedora-neuro
TreeView+ depends on / blocked
 
Reported: 2015-12-06 10:43 UTC by Igor Gnatenko
Modified: 2015-12-28 22:58 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-12-28 22:58:49 UTC
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Igor Gnatenko 2015-12-06 10:43:06 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/python-pacpy.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/python-pacpy-1.0.1-1.fc24.src.rpm
Description: A module to calculate phase-amplitude coupling in Python.
Fedora Account System Username: ignatenkobrain

Comment 1 Zbigniew Jędrzejewski-Szmek 2015-12-08 21:37:22 UTC
+ license is OK (MIT)
+ license file is present, %license is used
+ latest version
+ new python template is used
+ summary and description are OK
+ no scriptlets
+ %check is present and tests pass
+ provides and requires look fine

Upstream requirements file specifies pytest and statsmodels.

You should Require: pytest also, or at least Recommend: to allow tests to run in the installed package.

statsmodels doesn't seem to be used for anything though.

rpmlint:
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

Package is APPROVED.

Comment 2 Gwyn Ciesla 2015-12-09 13:17:37 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-pacpy

Comment 3 Fedora Update System 2015-12-12 12:15:07 UTC
python-pacpy-1.0.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-adfc82fda6

Comment 4 Fedora Update System 2015-12-13 17:22:01 UTC
python-pacpy-1.0.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-pacpy'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-adfc82fda6

Comment 5 Fedora Update System 2015-12-28 22:58:46 UTC
python-pacpy-1.0.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.