Bug 1288835 (python-interfile) - Review Request: python-interfile - Python module for read/write/parse interfile
Summary: Review Request: python-interfile - Python module for read/write/parse interfile
Keywords:
Status: CLOSED ERRATA
Alias: python-interfile
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: python-simplewrap
Blocks: fedora-neuro
TreeView+ depends on / blocked
 
Reported: 2015-12-06 12:36 UTC by Igor Gnatenko
Modified: 2015-12-28 22:58 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-12-28 22:58:30 UTC
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Igor Gnatenko 2015-12-06 12:36:07 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/python-interfile.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/python-interfile-0.3.1-1.fc24.src.rpm
Description: Interfile read, write and convert.
Fedora Account System Username: ignatenkobrain

Comment 1 Zbigniew Jędrzejewski-Szmek 2015-12-08 21:56:52 UTC
Please extend %description. It should at least say what an "interfile" is. Also, what can you convert the interfile to?

+ license is OK (BSD)
+ license file is not present, but upstream has been notified
+ latest version
+ new python template is used
+ no scriptlets
+ %check is present and tests pass
+ provides and requires look fine

Package is APPROVED, please fix %description.

Comment 2 Zbigniew Jędrzejewski-Szmek 2015-12-12 16:06:40 UTC
This isn't much better :) The fact that this is a Python module is kind of obvious from the package name... It's the "interfile" that is cryptic.

Comment 3 Gwyn Ciesla 2015-12-12 17:23:05 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-interfile

Comment 4 Igor Gnatenko 2015-12-12 17:56:59 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #2)
> This isn't much better :) The fact that this is a Python module is kind of
> obvious from the package name... It's the "interfile" that is cryptic.

I updated description with some explanation...

Comment 5 Fedora Update System 2015-12-12 18:27:20 UTC
python-interfile-0.3.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-c3e180d1a9

Comment 6 Zbigniew Jędrzejewski-Szmek 2015-12-12 20:04:27 UTC
%description is nice. Maybe "Python module to read and write PET interfile format" would be better than "Pyhon module for read/write/parse interfile" (which has a typo and is awkward gramatically).

Comment 7 Fedora Update System 2015-12-13 17:21:46 UTC
python-interfile-0.3.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-interfile'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-c3e180d1a9

Comment 8 Fedora Update System 2015-12-28 22:58:28 UTC
python-interfile-0.3.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.