Red Hat Bugzilla – Bug 1293374
When worker killer is invoked, you get undefined method sort!
Last modified: 2016-02-10 10:29:53 EST
New commit detected on cfme/5.5.z:
Merge: 43e8378 a2a8c9b
Author: Oleg Barenboim <firstname.lastname@example.org>
AuthorDate: Mon Jan 11 17:05:28 2016 -0500
Commit: Oleg Barenboim <email@example.com>
CommitDate: Mon Jan 11 17:05:28 2016 -0500
Merge branch 'fix_system_limit_killer-ds' into '5.5.z'
Fix issue where sort! was called on an ActiveRecord::Relation.
The MiqServer#do_system_limit_exceeded method was calling sort! on an
ActiveRecord::Relation. The specs were added to verify, but then it
was also revealed that the sorting method was not sufficient anyway.
This fix removes the sort! and also fixes the sorting logic.
This issue was missed because it didn't have specs, but also because it
is rarely called, only happening when workers need to be killed due to
low system resources.
This was a clean cherry-pick from Jason's PR https://github.com/ManageIQ/manageiq/pull/5916
See merge request !700
app/models/miq_server/worker_management/monitor.rb | 7 ++----
spec/factories/miq_worker.rb | 5 +++-
spec/models/miq_server/worker_monitor_spec.rb | 27 +++++++++++++++++++++-
3 files changed, 32 insertions(+), 7 deletions(-)
Ok, it appears to be working on 188.8.131.52
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.