Bug 1296805 - cannot enable internet network access for builds without enabling it in project settings
Summary: cannot enable internet network access for builds without enabling it in proje...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Copr
Classification: Community
Component: frontend
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: clime
QA Contact:
URL:
Whiteboard:
: 1277955 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-01-08 07:26 UTC by Jens Petersen
Modified: 2016-02-04 08:58 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-02-04 08:58:08 UTC
Embargoed:


Attachments (Terms of Use)

Description Jens Petersen 2016-01-08 07:26:36 UTC
Description of problem:
Earlier one could enable network access on a per build basis
without having to enable it in the projects settings.

ie now if internet access is not enabled in settings then
setting it for a build does nothing.  I kind of hope this is a bug...
since for some projects it is useful to be able to only enable
it only for some specific builds.

How reproducible:
100%

Steps to Reproduce:
1. for a project with net access disabled in its settings
2. build a package (that needs net access) with internet access enabled

Actual results:
2. fails due to no net access (project internet setting seems to override)

Expected results:
2. expect build settings to override project settings

Additional info:
I believe this change of behaviour happened towards the end of 2015.

If project setting needs to be set for any kind of net access
then no point to show the option in the build page if it is disabled
for the project (or it could be renamed to "Disable internet access";).

I liked the original behaviour better: where one could enable net access
per builds even when it was disabled for the project.

Alternatively one could have an additional checkbox in project Settings
to set the project default of whether net access is enabled by default
for builds or not.

Comment 1 clime 2016-01-28 06:35:09 UTC
Fixed by 66caa7fccc

Comment 2 clime 2016-01-28 06:52:24 UTC
*** Bug 1277955 has been marked as a duplicate of this bug. ***

Comment 3 Miroslav Suchý 2016-02-03 12:28:40 UTC
Code with this fix is currently deployed on copr-fe-dev.cloud.fedoraproject.org. You can test it there before it will be deployed to production.

Comment 4 Miroslav Suchý 2016-02-04 08:58:08 UTC
This fix has been just deployed to production.


Note You need to log in before you can comment on or make changes to this bug.