Bug 1297454 - [SR-IOV] - REST API - No validation for 'passthrough' profile in DCs less than 3.6
Summary: [SR-IOV] - REST API - No validation for 'passthrough' profile in DCs less tha...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 3.6.2
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ovirt-3.6.5
: 3.6.5
Assignee: Alona Kaplan
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-01-11 14:50 UTC by Michael Burman
Modified: 2016-04-21 14:42 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-21 14:42:17 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-3.6.z+
rule-engine: exception+
ylavi: planning_ack+
danken: devel_ack+
rule-engine: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 53429 0 master MERGED engine: No validation for 'passthrough' profile DCs less than 3.6 2016-02-21 08:26:26 UTC
oVirt gerrit 53767 0 ovirt-engine-3.6 MERGED engine: No validation for 'passthrough' profile DCs less than 3.6 2016-02-22 08:22:15 UTC

Description Michael Burman 2016-01-11 14:50:26 UTC
Description of problem:
[SR-IOV] - REST API - No validation for 'passthorugh' profile and vNIC type in clusters less then 3.6.

Currently there is no validation in clusters less then 3.6 for 'passthrough' profiles and 'pci-passthrough' vNIC types as should be. 

It is possible to end up with 'passthoruhg' profile in cluster 3.5 in the new 3.6.2 engine. 
The same for vNIC type of 'pci-passthoruhg'.  

Version-Release number of selected component (if applicable):
3.6.2-0.1.el6

How reproducible:
100

Steps to Reproduce:
1. Create vNIC profile with 'passthrough'' enabled in cluster 3.5 in engine 3.6.2 via REST
2. Create vNIC with 'pci-passthoruhg' type in cluster 3.5 in engine 3.6.2 via REST


Actual results:
Possible.

Expected results:
Should be blocked. Should be validation in clusters less then 3.6

Additional info:
See also BZ 1282441

Comment 1 Alona Kaplan 2016-02-11 15:04:10 UTC
It is necessary to fix just the vnic profile add/edit, to block creating 'passthrough' vnics in unsupported DCs.

There is no need to do the same blocking to the add/edit vnic. Since in case the vnics dc doesn't support sriov, it won't contain passthough profile. Therefore, after adding the blocking to the profiles, the user won't be able to create passthough vnic in this dc anyway.

Comment 2 Michael Burman 2016-04-03 11:19:49 UTC
Verified on - 3.6.5-0.1.el6


<fault>
<reason>Operation Failed</reason>
<detail>
[Cannot add VM network interface profile. Passthrough profile is not supported on the selected data center version.]
</detail>
</fault>

<fault>
<reason>Operation Failed</reason>
<detail>
[Cannot edit VM network interface profile. Passthrough profile is not supported on the selected data center version.]
</detail>
</fault>


Note You need to log in before you can comment on or make changes to this bug.