Bug 1298307 - nodejs-spdx-license-ids-2.0.0 is available
nodejs-spdx-license-ids-2.0.0 is available
Status: NEW
Product: Fedora
Classification: Fedora
Component: nodejs-spdx-license-ids (Show other bugs)
rawhide
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Zuzana Svetlikova
Fedora Extras Quality Assurance
: FutureFeature, Triaged
Depends On:
Blocks: 1298301
  Show dependency treegraph
 
Reported: 2016-01-13 12:32 EST by Upstream Release Monitoring
Modified: 2016-12-26 07:21 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Rebase-helper rebase-helper-debug.log log file. See for details and report the eventual error to rebase-helper https://github.com/phracek/rebase-helper/issues. (6.60 KB, patch)
2016-04-09 21:40 EDT, Upstream Release Monitoring
no flags Details | Diff
Rebase-helper rebase-helper-debug.log log file. See for details and report the eventual error to rebase-helper https://github.com/phracek/rebase-helper/issues. (14.40 KB, patch)
2016-07-26 08:32 EDT, Upstream Release Monitoring
no flags Details | Diff
Rebase-helper rebase-helper-debug.log log file. See for details and report the eventual error to rebase-helper https://github.com/phracek/rebase-helper/issues. (14.40 KB, patch)
2016-12-26 07:21 EST, Upstream Release Monitoring
no flags Details | Diff

  None (edit)
Description Upstream Release Monitoring 2016-01-13 12:32:35 EST
Latest upstream release: 1.2.0
Current version/release in rawhide: 1.0.1-1.fc23
URL: https://www.npmjs.org/package/spdx-license-ids

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.
Comment 1 Zbigniew Jędrzejewski-Szmek 2016-01-13 16:39:09 EST
It seems that there are mostly trivial changes, so upgrading should be fine.
Comment 2 Jared Smith 2016-01-13 16:40:04 EST
I'll go ahead and push this update tomorrow unless I hear differently from anyone.  I've got it built locally.
Comment 3 Piotr Popieluch 2016-01-13 17:08:34 EST
I don't see any depending packages so update should be without issues.


I've only found some minor issues with the package...

 - the packaged files should be built from source with:
      rm spdx-license-ids-browser.js
      node --harmony_arrow_functions build.js
 - BR on nodejs-devel is not needed
 - There are too many BR's for tests, do we really want to lint the source?
 - tests and build depends on newer nodejs (uses const keyword), this creates a circular dep...
 - build.js and bower.js don't need to be packaged, not sure about spdx-license-ids-browser.js
 - build scripts depend on stringify-object which is not packaged
Comment 4 Jared Smith 2016-01-14 16:19:12 EST
In the case of this package, I'm not sure it's really necessary to "build from source", since it's not really code, but just a list of licenses.

That being said, I've gone ahead and re-engineered the build process to use the jq utility instead of the 'build.js' file upstream.  The results are the same, but we don't end up needing a newer version of nodejs or network connectivity.

Tests still require a newer version of nodejs, so they're disabled for the moment.  In the long term, this will be fixed when we deploy a newer version of nodejs.  If anybody is ambitious in the short-term, they could re-write the test not to use the arrow notation, and remove the "const"s and probably come up with a useable test.

Without further ado...  Here's what I'll be pushing to Koji soon unless I get negative feedback first:

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-spdx-license-ids/nodejs-spdx-license-ids.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-spdx-license-ids/nodejs-spdx-license-ids-1.2.0-3.fc24.src.rpm
Comment 5 Piotr Popieluch 2016-01-14 17:15:34 EST
nice, looks good!

You might want to set EVR to 1.2.0-3 instead of 1.2.0-3
Comment 6 Upstream Release Monitoring 2016-01-14 17:30:14 EST
jsmith's nodejs-spdx-license-ids-1.2.0-3.fc24 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=711365
Comment 7 Upstream Release Monitoring 2016-02-04 09:57:35 EST
releng's nodejs-spdx-license-ids-1.2.0-4.fc24 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=724398
Comment 8 Upstream Release Monitoring 2016-04-09 21:39:57 EDT
Latest upstream release: 1.2.1
Current version/release in rawhide: 1.2.0-4.fc24
URL: https://www.npmjs.org/package/spdx-license-ids

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/8783/
Comment 9 Upstream Release Monitoring 2016-04-09 21:40:03 EDT
Patching or scratch build for nodejs-spdx-license-ids-1.2.0 failed.
Comment 10 Upstream Release Monitoring 2016-04-09 21:40:04 EDT
Created attachment 1145592 [details]
Rebase-helper rebase-helper-debug.log log file.
See for details and report the eventual error to rebase-helper https://github.com/phracek/rebase-helper/issues.
Comment 11 Upstream Release Monitoring 2016-04-09 21:40:06 EDT
Patches were not touched. All were applied properly
Comment 12 Upstream Release Monitoring 2016-07-26 08:32:41 EDT
Latest upstream release: 1.2.2
Current version/release in rawhide: 1.2.0-4.fc24
URL: https://www.npmjs.org/package/spdx-license-ids

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/8783/
Comment 13 Upstream Release Monitoring 2016-07-26 08:32:47 EDT
Patching or scratch build for nodejs-spdx-license-ids-1.2.0 failed.
Comment 14 Upstream Release Monitoring 2016-07-26 08:32:49 EDT
Created attachment 1184250 [details]
Rebase-helper rebase-helper-debug.log log file.
See for details and report the eventual error to rebase-helper https://github.com/phracek/rebase-helper/issues.
Comment 15 Upstream Release Monitoring 2016-07-26 08:32:51 EDT
Patches were not touched. All were applied properly
Comment 16 Upstream Release Monitoring 2016-12-26 07:21:00 EST
Latest upstream release: 2.0.0
Current version/release in rawhide: 1.2.0-4.fc24
URL: https://www.npmjs.org/package/spdx-license-ids

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/8783/
Comment 17 Upstream Release Monitoring 2016-12-26 07:21:06 EST
Patching or scratch build for nodejs-spdx-license-ids-1.2.0 failed.
Comment 18 Upstream Release Monitoring 2016-12-26 07:21:08 EST
Created attachment 1235386 [details]
Rebase-helper rebase-helper-debug.log log file.
See for details and report the eventual error to rebase-helper https://github.com/phracek/rebase-helper/issues.
Comment 19 Upstream Release Monitoring 2016-12-26 07:21:10 EST
Patches were not touched. All were applied properly

Note You need to log in before you can comment on or make changes to this bug.