Bug 1298301 - Review Request: nodejs-spdx-correct - Correct invalid SPDX identifiers
Summary: Review Request: nodejs-spdx-correct - Correct invalid SPDX identifiers
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1298269 1298307
Blocks: nodejs-reviews 1298310
TreeView+ depends on / blocked
 
Reported: 2016-01-13 17:13 UTC by Jared Smith
Modified: 2016-01-15 12:47 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-01-15 12:47:50 UTC
Type: ---
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Jared Smith 2016-01-13 17:13:29 UTC
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-spdx-correct/nodejs-spdx-correct.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-spdx-correct/nodejs-spdx-correct-1.0.2-1.fc24.src.rpm
Description: Correct invalid SPDX identifiers
Fedora Account System Username: jsmith

Comment 1 Jared Smith 2016-01-13 17:38:35 UTC
This package also depends on a newer version of nodejs-spdx-license-ids.

Comment 2 Zbigniew Jędrzejewski-Szmek 2016-01-13 21:26:43 UTC
%description should start with a capital letter and end with a dot.
Please put something there that it not the same as %summary.

+ license is OK (apache 2.0)
+ license is specified correctly
+ latest version
+ builds and installs OK
+ spec file looks fine
+ fedora-review is happy
+ provides/requires look sane

rpmlint is OK:
nodejs-spdx-correct.noarch: W: only-non-binary-in-usr-lib
nodejs-spdx-correct.noarch: W: dangling-symlink /usr/lib/node_modules/spdx-correct/node_modules/spdx-license-ids /usr/lib/node_modules/spdx-license-ids
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Package is APPROVED.

Comment 3 Patrick Uiterwijk 2016-01-14 23:16:59 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/nodejs-spdx-correct


Note You need to log in before you can comment on or make changes to this bug.