Spec URL: https://jvcelak.fedorapeople.org/review/socketIO-client/0.6.5-1/socketIO-client.spec SRPM URL: https://jvcelak.fedorapeople.org/review/socketIO-client/0.6.5-1/socketIO-client-0.6.5-1.fc23.src.rpm Description: The socketIO-client is a Python client library for socket.io. Fedora Account System Username: jvcelak COPR build: https://copr.fedoraproject.org/coprs/jvcelak/ripe-atlas-tools/package/socketIO-client/
*** Bug 1116178 has been marked as a duplicate of this bug. ***
Should be named python-... https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29
(In reply to Matthias Runge from comment #2) > Should be named python-... > > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_. > 28python_modules.29 Matthias, the name of the upstream project is socketIO-client. So is the name of the spec file. The builds results into two packages: python2-socketIO-client and python3-socketIO-client. So I believe this is compliant with the guidelines.
Jan, it's the same as for all other python libraries. One can differ from python-foo namimg scheme, if you're building something like a executable implemented in python. In this case, it's a library.
You are right Matthias. Updated packages follow: Spec URL: https://jvcelak.fedorapeople.org/review/socketIO-client/0.6.5-2/python-socketIO-client.spec SRPM URL: https://jvcelak.fedorapeople.org/review/socketIO-client/0.6.5-2/python-socketIO-client-0.6.5-1.fc23.src.rpm COPR build: https://copr.fedoraproject.org/coprs/jvcelak/ripe-atlas-tools/package/python-socketIO-client/
adding note for fedora-review with fixed build number Spec URL: https://jvcelak.fedorapeople.org/review/socketIO-client/0.6.5-2/python-socketIO-client.spec SRPM URL: https://jvcelak.fedorapeople.org/review/socketIO-client/0.6.5-2/python-socketIO-client-0.6.5-2.fc23.src.rpm COPR build: https://copr.fedoraproject.org/coprs/jvcelak/ripe-atlas-tools/package/python-socketIO-client/
so i am not running rawhide and so I'm running into issues with python2-six not being available. Searching yum, it seems it should be able to do both: python-six.noarch : Python 2 and 3 compatibility utilities They really made python a giant mess :(
Review: PASSED Care should be taken with regards to python vs python2 in the various branches. Tests for make check are not working, upstream should be notified Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 12 files have unknown license. Detailed output of licensecheck in /home/paul/review- python-socketIO-client/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3 -socketIO-client , python2-socketIO-client [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. check is disabled because it seems to run extremely long, might be stuck [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-socketIO-client-0.6.5-2.fc22.noarch.rpm python2-socketIO-client-0.6.5-2.fc22.noarch.rpm python-socketIO-client-0.6.5-2.fc22.src.rpm python3-socketIO-client.noarch: W: spelling-error Summary(en_US) io -> oi, Io, ii python3-socketIO-client.noarch: W: spelling-error %description -l en_US io -> oi, Io, ii python2-socketIO-client.noarch: W: spelling-error Summary(en_US) io -> oi, Io, ii python2-socketIO-client.noarch: W: spelling-error %description -l en_US io -> oi, Io, ii python-socketIO-client.src: W: spelling-error Summary(en_US) io -> oi, Io, ii python-socketIO-client.src: W: spelling-error %description -l en_US io -> oi, Io, ii python-socketIO-client.src:65: W: macro-in-comment %__python2 python-socketIO-client.src:66: W: macro-in-comment %__python3 3 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- python2-socketIO-client.noarch: W: spelling-error Summary(en_US) io -> oi, Io, ii python2-socketIO-client.noarch: W: spelling-error %description -l en_US io -> oi, Io, ii python3-socketIO-client.noarch: W: spelling-error Summary(en_US) io -> oi, Io, ii python3-socketIO-client.noarch: W: spelling-error %description -l en_US io -> oi, Io, ii 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- python2-socketIO-client (rpmlib, GLIBC filtered): python(abi) python-requests python-six python-websocket-client python3-socketIO-client (rpmlib, GLIBC filtered): python(abi) python3-requests python3-six python3-websocket-client Provides -------- python2-socketIO-client: python-socketIO-client python2-socketIO-client python3-socketIO-client: python3-socketIO-client Source checksums ---------------- https://github.com/invisibleroads/socketIO-client/archive/v0.6.5.tar.gz#/socketIO-client-0.6.5.tar.gz : CHECKSUM(SHA256) this package : b1defde04949cc5dc8021264fd9a3905f738ed9b1845c4925d324815d35bc4be CHECKSUM(SHA256) upstream package : b1defde04949cc5dc8021264fd9a3905f738ed9b1845c4925d324815d35bc4be Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -n python-socketIO-client Buildroot used: fedora-22-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to Paul Wouters from comment #7) > so i am not running rawhide and so I'm running into issues with python2-six > not being available. Searching yum, it seems it should be able to do both: > > python-six.noarch : Python 2 and 3 compatibility utilities > > They really made python a giant mess :( Completely unrelated to this review: In Rawhide: rpm -qp --provides python-six-1.10.0-1.fc24.noarch.rpm python-six = 1.10.0-1.fc24 python2-six = 1.10.0-1.fc24 and in fedora 23: rpm -q --provides python-six python-six = 1.9.0-3.fc23 python2-six Hmmm. I see a provides line in the spec, Provides: python2-six = %{version}-%{release} Otherwise I'd obsolete python-six to be sure to really replace python-six with python2-six, adding the python_provides-macro to python-six spec should fix that.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-socketIO-client
python-socketIO-client-0.6.5-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-442278716c
Thank you, guys!
python-socketIO-client-0.6.5-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-442278716c
python-socketIO-client-0.6.5-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.