Spec URL: https://jvcelak.fedorapeople.org/review/ripe-atlas-cousteau/1.0.7-1/ripe-atlas-cousteau.spec SRPM URL: https://jvcelak.fedorapeople.org/review/ripe-atlas-cousteau/1.0.7-1/ripe-atlas-cousteau-1.0.7-1.fc23.src.rpm Description: Python wrapper for RIPE Atlas API Fedora Account System Username: jvcelak COPR builds: https://copr.fedoraproject.org/coprs/jvcelak/ripe-atlas-tools/package/ripe-atlas-cousteau/ The package depends on socketIO-client, which is under a review #1300092.
This package should be named python-.... https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29
Renamed. Spec URL: https://jvcelak.fedorapeople.org/review/ripe-atlas-cousteau/1.0.7-2/python-ripe-atlas-cousteau.spec SRPM URL: https://jvcelak.fedorapeople.org/review/ripe-atlas-cousteau/1.0.7-2/python-ripe-atlas-cousteau-1.0.7-2.fc23.src.rpm COPR builds: https://copr.fedoraproject.org/coprs/jvcelak/ripe-atlas-tools/package/python-ripe-atlas-cousteau/
Updated to newer upstream version: Spec URL: https://jvcelak.fedorapeople.org/review/ripe-atlas-cousteau/1.2-1/python-ripe-atlas-cousteau.spec SRPM URL: https://jvcelak.fedorapeople.org/review/ripe-atlas-cousteau/1.2-1/python-ripe-atlas-cousteau-1.2-1.fc23.src.rpm COPR builds: https://copr.fedoraproject.org/coprs/jvcelak/ripe-atlas-tools/package/python-ripe-atlas-cousteau/
PASSED I might have explicitely made the ripe sitearch directory owned by this package, but the glob seems to drag it in fine. I am wondering about these: python3-ripe-atlas-cousteau.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/ripe/atlas/cousteau/__pycache__/source.cpython-35.opt-1.pyc I assume it is some artifact that rpmlint isn't fully aware of yet? Paul This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /tmp/1300219 -python-ripe-atlas-cousteau/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.5/site-packages, /usr/lib/python3.5, /usr/share/licenses [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.5/site- packages, /usr/share/licenses, /usr/lib/python3.5 PAUL: should it not own the site-packages/ripe directories? PAUL: at least one of the packages should own it [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3 -ripe-atlas-cousteau , python2-ripe-atlas-cousteau [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-ripe-atlas-cousteau-1.2-1.fc25.noarch.rpm python2-ripe-atlas-cousteau-1.2-1.fc25.noarch.rpm python-ripe-atlas-cousteau-1.2-1.fc25.src.rpm python3-ripe-atlas-cousteau.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/ripe/atlas/cousteau/__pycache__/source.cpython-35.opt-1.pyc python3-ripe-atlas-cousteau.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/ripe/atlas/cousteau/__pycache__/exceptions.cpython-35.opt-1.pyc python3-ripe-atlas-cousteau.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/ripe/atlas/cousteau/__pycache__/api_listing.cpython-35.opt-1.pyc python3-ripe-atlas-cousteau.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/ripe/atlas/cousteau/__pycache__/stream.cpython-35.opt-1.pyc python3-ripe-atlas-cousteau.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/ripe/atlas/cousteau/__pycache__/api_meta_data.cpython-35.opt-1.pyc python3-ripe-atlas-cousteau.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/ripe/atlas/cousteau/__pycache__/version.cpython-35.opt-1.pyc python3-ripe-atlas-cousteau.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/ripe/atlas/cousteau/__pycache__/measurement.cpython-35.opt-1.pyc python3-ripe-atlas-cousteau.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/ripe/atlas/cousteau/__pycache__/request.cpython-35.opt-1.pyc python3-ripe-atlas-cousteau.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/ripe/atlas/cousteau/__pycache__/__init__.cpython-35.opt-1.pyc 3 packages and 0 specfiles checked; 0 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- python2-ripe-atlas-cousteau (rpmlib, GLIBC filtered): python(abi) python-dateutil python2-requests python2-socketIO-client python3-ripe-atlas-cousteau (rpmlib, GLIBC filtered): python(abi) python3-dateutil python3-requests python3-socketIO-client Provides -------- python2-ripe-atlas-cousteau: python-ripe-atlas-cousteau python2-ripe-atlas-cousteau python3-ripe-atlas-cousteau: python3-ripe-atlas-cousteau Source checksums ---------------- https://pypi.python.org/packages/source/r/ripe.atlas.cousteau/ripe.atlas.cousteau-1.2.tar.gz : CHECKSUM(SHA256) this package : 0b4ed516478fb6a9e2268dc68eca86722961ec4209f9e54fe37564765c56025e CHECKSUM(SHA256) upstream package : 0b4ed516478fb6a9e2268dc68eca86722961ec4209f9e54fe37564765c56025e Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1300219 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
One minor nit: Please do not use macros in the URL: entry. These entries should be updated for each package anywya, and it prevents someone from looking in the spec file and right-clicking to go to the site.
NOTE: the site-packages/ripe package directory is also owned by other ripe packages.
(In reply to Paul Wouters from comment #4) > python3-ripe-atlas-cousteau.noarch: W: python-bytecode-without-source > /usr/lib/python3.5/site-packages/ripe/atlas/cousteau/__pycache__/source. > cpython-35.opt-1.pyc I'll recheck what's going on. (In reply to Paul Wouters from comment #5) > One minor nit: Please do not use macros in the URL: entry. These entries > should be updated for each package anywya, and it prevents someone from > looking in the spec file and right-clicking to go to the site. OK. I'll remove the URL. (In reply to Paul Wouters from comment #6) > NOTE: the site-packages/ripe package directory is also owned by other ripe > packages. I think this is correct in this case. And also allowed by the guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function Thank you, Paul!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-ripe-atlas-cousteau
python-ripe-atlas-cousteau-1.2-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9cf2f3ee04
python-ripe-atlas-cousteau-1.2-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0cc7f0037a
python-ripe-atlas-cousteau-1.2-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9cf2f3ee04
python-ripe-atlas-cousteau-1.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0cc7f0037a
python-ripe-atlas-cousteau-1.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
python-ripe-atlas-cousteau-1.2-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.