Red Hat Bugzilla – Bug 1301714
Cannot not approve VM provision requests in the UI
Last modified: 2016-02-10 10:36:11 EST
Here are the details of the MR for the 22.214.171.124 build:
New commit detected on cfme/5.5.z:
Author: Keenan Brock <email@example.com>
AuthorDate: Tue Jan 26 11:09:31 2016 -0500
Commit: Greg McCullough <firstname.lastname@example.org>
CommitDate: Tue Jan 26 18:29:49 2016 -0500
FIX: Approve Vm provisioning in UI
The workflow requester is set to the current_user.
The group context for the request was then being set in the the
current_user, corrupting it.
1. MiqRequestWorkflow#requester = MiqRequest#requester
so the correct dialogs will be displayed.
2. Requester is cloned before setting the group as a precaution.
This assumes the viewer and administrator can see the resources that
the requester has access to view as well.
app/controllers/application_controller/miq_request_methods.rb | 2 +-
app/models/miq_request_workflow.rb | 6 +++++-
2 files changed, 6 insertions(+), 2 deletions(-)
What is the correct way to create a role without approve rights?
I think a self service user does not have approval rights.
The bug is when an admin (with privs and many groups) views a request,
the admin is moved into the group of the user who created the request.
So privileges go away, since the buttons are based upon the user's group in the view.
Kevin Morey created the ticket and may be able to help you reproduce.
Using admin user, I created a provision request for 3 vms, which does not get automatic approval because gt 1, then I was able to approve it. Also tried deny without issue. Good to go.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.