Bug 1302010 - pcs property show <property> shows all node properties unfiltered
Summary: pcs property show <property> shows all node properties unfiltered
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: pcs
Version: 7.3
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Tomas Jelinek
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-01-26 14:18 UTC by Michele Baldessari
Modified: 2016-11-03 20:56 UTC (History)
6 users (show)

Fixed In Version: pcs-0.9.152-5.el7
Doc Type: Bug Fix
Doc Text:
Cause: User wants to list cluster properties matching specified name. Consequence: All node properties are listed. Fix: Filter node properties by specified name. Result: Only properties matching the name are listed.
Clone Of:
Environment:
Last Closed: 2016-11-03 20:56:37 UTC
Target Upstream Version:


Attachments (Terms of Use)
proposed fix (11.21 KB, patch)
2016-07-22 10:08 UTC, Tomas Jelinek
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1301993 0 low CLOSED [RFE] pcs property list/show could have a --node filter 2021-02-22 00:41:40 UTC
Red Hat Product Errata RHSA-2016:2596 0 normal SHIPPED_LIVE Moderate: pcs security, bug fix, and enhancement update 2016-11-03 12:11:34 UTC

Internal Links: 1301993

Description Michele Baldessari 2016-01-26 14:18:49 UTC
Here are my current properties:
# pcs property
Cluster Properties:
 bar: bandini
 cluster-infrastructure: corosync
 cluster-name: cluster_name
 dc-version: 1.1.13-10.el7-44eb2dd
 have-watchdog: false
 stonith-enabled: false
Node Attributes:
 centos: foo=bar


I was surprised that when showing a non existing property:
# pcs property show baz
Cluster Properties:
Node Attributes:
 centos: foo=bar

I think it should show only the node properties that match the property asked
on the command line. (aka none in this case). Related to BZ#1301993

Comment 2 Tomas Jelinek 2016-01-28 11:38:28 UTC
Node properties should be moved to "pcs node" command.

Comment 3 Tomas Jelinek 2016-07-22 10:08:08 UTC
Created attachment 1182767 [details]
proposed fix

Comment 5 Ivan Devat 2016-07-29 07:12:06 UTC
Setup:
[vm-rhel72-1 ~] $ pcs node standby vm-rhel72-3
[vm-rhel72-1 ~] $ pcs property
Cluster Properties:
 cluster-infrastructure: corosync
 cluster-name: devcluster
 dc-version: 1.1.15-7.el7-e174ec8
 have-watchdog: false
Node Attributes:
 vm-rhel72-3: standby=on

Before Fix:
[vm-rhel72-1 ~] $ rpm -q pcs
pcs-0.9.152-4.el7.x86_64
[vm-rhel72-1 ~] $ pcs property show baz
Cluster Properties:
Node Attributes:
 vm-rhel72-3: standby=on

After Fix:
[vm-rhel72-1 ~] $ rpm -q pcs
pcs-0.9.152-5.el7.x86_64
[vm-rhel72-1 ~] $ pcs property show baz
Cluster Properties:

Comment 8 errata-xmlrpc 2016-11-03 20:56:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2596.html


Note You need to log in before you can comment on or make changes to this bug.