Bug 1304966 - DHT: Take blocking locks while renaming files
Summary: DHT: Take blocking locks while renaming files
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: mainline
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Sakshi
QA Contact:
Depends On:
Blocks: 1305836 1310544
TreeView+ depends on / blocked
Reported: 2016-02-05 06:59 UTC by Sakshi
Modified: 2016-08-01 01:22 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1305836 1310544 (view as bug list)
Last Closed: 2016-06-16 13:57:06 UTC
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:

Attachments (Terms of Use)

Description Sakshi 2016-02-05 06:59:03 UTC
Description of problem:
DHT takes non-blocking locks while renaming files. During parallel renames and parallel rebalance and rename clients might fail with EBUSY or ESTALE errors. Hence to avoid application discontinuity renaming of files must take blocking locks.

Hence it is better to take blocking locks for renaming files.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:

Actual results:

Expected results:

Additional info:

Comment 1 Vijay Bellur 2016-02-05 09:26:34 UTC
REVIEW: http://review.gluster.org/13366 (dht: file rename must take blocking inode locks) posted (#1) for review on master by Sakshi Bansal

Comment 2 Vijay Bellur 2016-02-22 06:39:36 UTC
COMMIT: http://review.gluster.org/13366 committed in master by Raghavendra G (rgowdapp@redhat.com) 
commit f02dc88786afea06e6b064a724803c82a0af90ba
Author: Sakshi Bansal <sabansal@redhat.com>
Date:   Fri Feb 5 14:51:10 2016 +0530

    dht: file rename must take blocking inode locks
    Currently DHT takes non-blocking locks for file rename.
    Due to this during parallel renames some clients fail
    with EBUSY or ESTALE errors. Hence to avoid application
    discontinuity file rename must take blocking inode locks.
    Change-Id: I986e9d08b3be359f20b1a3e1564e049b0f3dffd3
    BUG: 1304966
    Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
    Reviewed-on: http://review.gluster.org/13366
    Smoke: Gluster Build System <jenkins@build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
    Reviewed-by: Raghavendra G <rgowdapp@redhat.com>

Comment 3 Niels de Vos 2016-06-16 13:57:06 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Note You need to log in before you can comment on or make changes to this bug.