Red Hat Bugzilla – Bug 1306331
Typo in "Selinux Level" property for non-privileged container
Last modified: 2016-06-29 11:37:22 EDT
Created attachment 1122825 [details] Screenshot Description of problem: Non-privileged containers show selinux level correctly, but the header has a typo: 'Se Linux Level' Version-Release number of selected component (if applicable): 5.5.2.4 How reproducible: Always Steps to Reproduce: 1. Add openshift provider 2. Select any non-privileged container 3. Check Properties table Actual results: selinux level header has a typo Expected results: All table columns have correct information Additional info:
Beni can you take a look? Thanks!
Wrote trivial fix https://github.com/cben/manageiq/commit/b2d717b4baca22387d22ed27a05659010f28f313 but can't currently test (new on the team, got working OpenShift & ManageIQ but I'm still struggling to connect them...)
(In reply to Vadim Rutkovsky from comment #0) > Actual results: > selinux level header has a typo Vadim can you validate that the correct header is what Beni proposed in his patch. Thanks-
(In reply to Federico Simoncelli from comment #3) > (In reply to Vadim Rutkovsky from comment #0) > > Actual results: > > selinux level header has a typo > > Vadim can you validate that the correct header is what Beni proposed in his > patch. > Thanks- Yep, the patch fixes this, thanks!
Created attachment 1127240 [details] screenshot after https://github.com/ManageIQ/manageiq/commit/ad5a33a3e1e150ff58ee46bc7364272a5c940226 Yes, got my env working too, attached screenshot, sending PR... The patch should also fix "SELinux User", "SELinux Role", "SELinux Type" strings — didn't see those in action, according to code they only appear if the info is there.
https://github.com/ManageIQ/manageiq/pull/6664
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/ad5a33a3e1e150ff58ee46bc7364272a5c940226 commit ad5a33a3e1e150ff58ee46bc7364272a5c940226 Author: Beni Cherniavsky-Paskin <cben@redhat.com> AuthorDate: Thu Feb 11 17:41:12 2016 +0200 Commit: Beni Cherniavsky-Paskin <cben@redhat.com> CommitDate: Mon Feb 15 14:26:12 2016 +0200 Fix typo "Se Linux" -> "SELinux" https://bugzilla.redhat.com/show_bug.cgi?id=1306331 app/helpers/container_helper/textual_summary.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=0ab9979998bfeb774b535c3c35b6aea058d3308a commit 0ab9979998bfeb774b535c3c35b6aea058d3308a Author: Beni Cherniavsky-Paskin <cben@redhat.com> AuthorDate: Thu Feb 11 17:41:12 2016 +0200 Commit: Beni Cherniavsky-Paskin <cben@redhat.com> CommitDate: Mon Feb 22 14:41:03 2016 +0200 Fix typo "Se Linux" -> "SELinux" https://bugzilla.redhat.com/show_bug.cgi?id=1306331 app/helpers/container_helper/textual_summary.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Dave, I really don't think we should start covering typos as test cases, it'll be an over kill and also useless. TestCase, is a flow that you suspect to be broken every once in a while. Fixing specific typo shouldn't rerun every build/release .. once it was fixed. So, this bug should stay as verify without test case.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1348