Bug 1308414 - AFR: cluster options like data-self-heal, metadata-self-heal and entry-self-heal should not be allowed to set, if volume is not distribute-replicate volume
Summary: AFR: cluster options like data-self-heal, metadata-self-heal and entry-self-h...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: 3.7.7
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Sakshi
QA Contact:
URL:
Whiteboard:
Depends On: 1234995 1265479
Blocks: 1223636
TreeView+ depends on / blocked
 
Reported: 2016-02-15 06:43 UTC by Sakshi
Modified: 2016-08-01 01:22 UTC (History)
7 users (show)

Fixed In Version: glusterfs-3.7.9
Doc Type: Bug Fix
Doc Text:
Clone Of: 1265479
Environment:
Last Closed: 2016-04-15 05:14:32 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Sakshi 2016-02-15 06:43:42 UTC
+++ This bug was initially created as a clone of Bug #1265479 +++

+++ This bug was initially created as a clone of Bug #1234995 +++

Description of problem:

When you have distribute or disperse volume, and you set data-self-heal, metadata-self-heal and entry-self-heal options on/off  it succeeds. 

Since when you try to set self-heal-daemon off/on on distribute, disperse volume , it give error self-heal-daemon can be set on distribute-replicate volume. Same error should be displayed when user tries to set data-self-heal, metadata-self-heal and entry-self-heal options on/off.


Version-Release number of selected component (if applicable):

[root@darkknightrises ~]# rpm -qa | grep glusterfs
glusterfs-client-xlators-3.7.1-4.el6rhs.x86_64
glusterfs-cli-3.7.1-4.el6rhs.x86_64
samba-vfs-glusterfs-4.1.17-7.el6rhs.x86_64
glusterfs-libs-3.7.1-4.el6rhs.x86_64
glusterfs-3.7.1-4.el6rhs.x86_64
glusterfs-api-3.7.1-4.el6rhs.x86_64
glusterfs-server-3.7.1-4.el6rhs.x86_64
glusterfs-debuginfo-3.7.1-4.el6rhs.x86_64
glusterfs-fuse-3.7.1-4.el6rhs.x86_64
glusterfs-geo-replication-3.7.1-4.el6rhs.x86_64


How reproducible:

100%

Steps to Reproduce:
1. Create distribute volume
2. set data-self-heal, metadata-self-heal and entry-self-heal option on/off. e.g gluster v set <vol-name> data-self-heal off
3. 

Actual results:

Commands succeeds 

Expected results:

Check should there, if there is distribute-replicate volume , then only data-self-heal, metadata-self-heal and entry-self-heal option should be allowed to set

--- Additional comment from Sakshi on 2015-11-02 01:07:02 EST ---

Patch upstream http://review.gluster.org/12215

Comment 1 Vijay Bellur 2016-02-15 06:46:55 UTC
REVIEW: http://review.gluster.org/13444 (glusterd: validate function for replica volume options) posted (#1) for review on release-3.7 by Sakshi Bansal

Comment 2 Vijay Bellur 2016-02-22 06:44:47 UTC
COMMIT: http://review.gluster.org/13444 committed in release-3.7 by Atin Mukherjee (amukherj) 
------
commit 976c852eeb8af0abfad8862e5b53e3d82c79ee98
Author: Sakshi <sabansal>
Date:   Wed Sep 23 15:16:34 2015 +0530

    glusterd: validate function for replica volume options
    
    Backport of http://review.gluster.org/#/c/12215/
    
    > Change-Id: I5b4a28db101e9f7e07f4b388c7a2594051c9e8dd
    > BUG: 1265479
    > Signed-off-by: Sakshi <sabansal>
    > Reviewed-on: http://review.gluster.org/12215
    > Tested-by: NetBSD Build System <jenkins.org>
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Atin Mukherjee <amukherj>
    
    BUG: 1308414
    Change-Id: I1ce7c326da82749f8fd13dff11b803c607c853bb
    Signed-off-by: Sakshi <sabansal>
    Reviewed-on: http://review.gluster.org/13444
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 3 Kaushal 2016-04-19 07:24:20 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.9, please open a new bug report.

glusterfs-3.7.9 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-March/025922.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.