Bug 1310080 - [RFE]Add --no-encode option to the `glusterfind pre` command
Summary: [RFE]Add --no-encode option to the `glusterfind pre` command
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterfind
Version: mainline
Hardware: All
OS: All
medium
medium
Target Milestone: ---
Assignee: Aravinda VK
QA Contact: bugs@gluster.org
URL:
Whiteboard:
Depends On: 1309277
Blocks: 1313310
TreeView+ depends on / blocked
 
Reported: 2016-02-19 12:11 UTC by Aravinda VK
Modified: 2016-06-16 13:57 UTC (History)
4 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Enhancement
Doc Text:
Clone Of: 1309277
: 1313310 (view as bug list)
Environment:
Last Closed: 2016-06-16 13:57:48 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:


Attachments (Terms of Use)

Description Aravinda VK 2016-02-19 12:11:46 UTC
+++ This bug was initially created as a clone of Bug #1309277 +++

Description of problem:

Glusterfind intentionally encodes(RFC 3986 https://www.ietf.org/rfc/rfc3986.txt) the file/dir path. Since the encoded file names are difficult to follow, there must an option to choose not to encode the glusterfind pre output file. 

Version-Release number of selected component (if applicable):

RHGS 3.1.1

How reproducible:

Always

Steps to Reproduce:

1. create a glusterfind session 

2. make some new directories or files with Russian name(Eg:-тестирование\ гластерфайнд)

3. Generate out file ,using glusterfind pre

Actual results:

test2%2F%2F%D1%82%D0%B5%D1%81%D1%82%D0%B8%D1%80%D0%BE%D0%B2%D0%B0%D0%BD%D0%B8%D0%B5+%D0%B3%D0%BB%D0%B0%D1%81%D1%82%D0%B5%D1%80%D1%84%D0%B0%D0%B9%D0%BD%D0%B4


Expected results:

test2//тестирование гластерфайнд



Additional info:

Comment 1 Vijay Bellur 2016-02-19 12:13:14 UTC
REVIEW: http://review.gluster.org/13477 (tools/glusterfind: New option --no-encode) posted (#1) for review on master by Aravinda VK (avishwan@redhat.com)

Comment 2 Vijay Bellur 2016-02-23 05:08:25 UTC
REVIEW: http://review.gluster.org/13477 (tools/glusterfind: New option --no-encode) posted (#2) for review on master by Aravinda VK (avishwan@redhat.com)

Comment 3 Vijay Bellur 2016-02-23 05:13:23 UTC
REVIEW: http://review.gluster.org/13477 (tools/glusterfind: New option --no-encode) posted (#3) for review on master by Aravinda VK (avishwan@redhat.com)

Comment 4 Vijay Bellur 2016-02-26 10:11:26 UTC
COMMIT: http://review.gluster.org/13477 committed in master by Venky Shankar (vshankar@redhat.com) 
------
commit 1b897c39ba8c0f1bf180316637cc2d87e6920800
Author: Aravinda VK <avishwan@redhat.com>
Date:   Fri Feb 19 17:08:56 2016 +0530

    tools/glusterfind: New option --no-encode
    
    New option added to skip encoding path in output file. Also handled
    Unicode strings.
    
    File paths can have newline characters, to differentiate between each
    path patch is encoded according to
    RFC3986(https://www.ietf.org/rfc/rfc3986.txt). Due to this consumer
    applications have to decode the path before consuming it. With this
    option Paths are not encoded, can be directly consumed by
    applications.
    
    Unicode encoding is handled automatically
    
    BUG: 1310080
    Change-Id: I83d59831997dbd1264b48e9b1aa732c7dfc700b5
    Signed-off-by: Aravinda VK <avishwan@redhat.com>
    Reviewed-on: http://review.gluster.org/13477
    Smoke: Gluster Build System <jenkins@build.gluster.com>
    Reviewed-by: Milind Changire <mchangir@redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
    Reviewed-by: Kotresh HR <khiremat@redhat.com>
    CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
    Reviewed-by: Venky Shankar <vshankar@redhat.com>

Comment 5 Niels de Vos 2016-06-16 13:57:48 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.