Bug 1312433 - [RFE] garbage collect stale replication controllers
Summary: [RFE] garbage collect stale replication controllers
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: RFE
Version: 3.1.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Michal Fojtik
QA Contact: zhou ying
URL: https://github.com/kubernetes/kuberne...
Whiteboard:
: 1326529 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-02-26 16:52 UTC by Evgheni Dereveanchin
Modified: 2019-12-16 05:26 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-28 11:38:26 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Evgheni Dereveanchin 2016-02-26 16:52:54 UTC 
Description of problem:
 Currently each deployment leaves a replication controller behind for rollback purposes. Eventually this leads to etcd getting filled with stale data. Also, if quotas are enforced, deployments will soon stop working due to replication controllers piling up, and the only way to clean them up is using "oadm prune"

Version-Release number of selected component (if applicable):
3.1.1

Proposed improvement:
 Allow setting replication controller limit per project or per deployment.

Additional info:
 upstream pull request was merged:
  https://github.com/kubernetes/kubernetes/pull/19590
Comment 2 Dan McPherson 2016-04-13 22:08:23 UTC 
*** Bug 1326529 has been marked as a duplicate of this bug. ***
Comment 3 Michail Kargakis 2016-04-18 14:25:51 UTC 
Related gh issue: https://github.com/openshift/origin/issues/6731
Comment 5 Steve Kuznetsov 2016-08-29 12:37:07 UTC 
Deployment cleanup policy was added in https://github.com/openshift/origin/issues/8691 

Michal, does that satisfy this?
Comment 6 Michail Kargakis 2016-08-29 12:42:31 UTC 
Yes, dc.spec.revisionHistoryLimit satisfies this bug.
Comment 7 zhou ying 2016-08-30 09:24:11 UTC 
Confirmed with OCP , the issue has fixed:
openshift v3.3.0.27
kubernetes v1.3.0+507d3a7
etcd 2.3.0+git

Auto cleanup the first RC, only retain the latest 3 RC;

oc get rc
NAME              DESIRED   CURRENT   AGE
history-limit-3   0         0         9m
history-limit-4   0         0         7m
history-limit-5   1         1         7m
Note You need to log in before you can comment on or make changes to this bug.