Red Hat Bugzilla – Bug 1315558
SEEK_HOLE and SEEK_DATA should return EINVAL when protocol support is missing
Last modified: 2016-08-16 09:11:27 EDT
+++ This bug was initially created as a clone of Bug #1315557 +++
Description of problem:
GlusterFS 3.7 and earlier do not have support for the (new) SEEK FOP. There is no check in glfs_lseek() for unknown SEEK_* operations, this needs to be added
Version-Release number of selected component (if applicable):
3.7 and before
Steps to Reproduce:
1. call glfs_lseek(..., ..., SEEK_DATA)
No error is returned.
-1 should get returned, and errno should have been set to EINVAL.
Found through code inspection while replying to http://lists.nongnu.org/archive/html/qemu-block/2016-03/msg00119.html
REVIEW: http://review.gluster.org/13633 (gfapi: return EINVAL for unsupported lseek() operations) posted (#1) for review on release-3.6 by Niels de Vos (email@example.com)
REVIEW: http://review.gluster.org/13633 (gfapi: return EINVAL for unsupported lseek() operations) posted (#2) for review on release-3.6 by Niels de Vos (firstname.lastname@example.org)
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see email@example.com with any questions
COMMIT: http://review.gluster.org/13633 committed in release-3.6 by Raghavendra Bhat (firstname.lastname@example.org)
Author: Niels de Vos <email@example.com>
Date: Tue Mar 8 05:39:01 2016 +0100
gfapi: return EINVAL for unsupported lseek() operations
GlusterFS 3.8 contains support for SEEK_DATA/SEEK_HOLE. This protocol
extension is not available in 3.6. libgfapi needs to handle unsupported
SEEK_* operations correctly, by returning -1 and setting errno to
This change is different from the patch in the master branch, it is only
needed to do the improved error checking in this version.
Signed-off-by: Niels de Vos <firstname.lastname@example.org>
Smoke: Gluster Build System <email@example.com>
NetBSD-regression: NetBSD Build System <firstname.lastname@example.org>
CentOS-regression: Gluster Build System <email@example.com>
Reviewed-by: Shyamsundar Ranganathan <firstname.lastname@example.org>
Reviewed-by: Raghavendra Bhat <email@example.com>
This bug is being closed as GlusterFS-3.6 is nearing its End-Of-Life and only important security bugs will be fixed. This bug has been fixed in more recent GlusterFS releases. If you still face this bug with the newer GlusterFS versions, please open a new bug.
In case glusterfs-3.6.10 gets released, the fix will be included automatically. It is highly recommended to use a newer glusterfs version.