Description of problem: GlusterFS 3.7 and earlier do not have support for the (new) SEEK FOP. There is no check in glfs_lseek() for unknown SEEK_* operations, this needs to be added Version-Release number of selected component (if applicable): 3.7 and before How reproducible: 100% Steps to Reproduce: 1. call glfs_lseek(..., ..., SEEK_DATA) Actual results: No error is returned. Expected results: -1 should get returned, and errno should have been set to EINVAL. Additional info: Found through code inspection while replying to http://lists.nongnu.org/archive/html/qemu-block/2016-03/msg00119.html
REVIEW: http://review.gluster.org/13631 (gfapi: return EINVAL for unsupported lseek() operations) posted (#1) for review on release-3.7 by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/13631 (gfapi: return EINVAL for unsupported lseek() operations) posted (#2) for review on release-3.7 by Vijay Bellur (vbellur)
COMMIT: http://review.gluster.org/13631 committed in release-3.7 by Vijay Bellur (vbellur) ------ commit ba1a401e142ad8884f9d3f13c51f7d5b17d008fc Author: Niels de Vos <ndevos> Date: Tue Mar 8 05:39:01 2016 +0100 gfapi: return EINVAL for unsupported lseek() operations GlusterFS 3.8 contains support for SEEK_DATA/SEEK_HOLE. This protocol extension is not available in 3.7. libgfapi needs to handle unsupported SEEK_* operations correctly, by returning -1 and setting errno to EINVAL. This change is different from the patch in the master branch, it is only needed to do the improved error checking in this version. BUG: 1315557 Change-Id: I142dde11923244809b03fcca8cd4c2f7d5ff3929 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/13631 Smoke: Gluster Build System <jenkins.com> Reviewed-by: Shyamsundar Ranganathan <srangana> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.9, please open a new bug report. glusterfs-3.7.9 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-users/2016-March/025922.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user