Red Hat Bugzilla – Bug 1315557
SEEK_HOLE and SEEK_DATA should return EINVAL when protocol support is missing
Last modified: 2016-04-19 03:20:46 EDT
Description of problem:
GlusterFS 3.7 and earlier do not have support for the (new) SEEK FOP. There is no check in glfs_lseek() for unknown SEEK_* operations, this needs to be added
Version-Release number of selected component (if applicable):
3.7 and before
Steps to Reproduce:
1. call glfs_lseek(..., ..., SEEK_DATA)
No error is returned.
-1 should get returned, and errno should have been set to EINVAL.
Found through code inspection while replying to http://lists.nongnu.org/archive/html/qemu-block/2016-03/msg00119.html
REVIEW: http://review.gluster.org/13631 (gfapi: return EINVAL for unsupported lseek() operations) posted (#1) for review on release-3.7 by Niels de Vos (email@example.com)
REVIEW: http://review.gluster.org/13631 (gfapi: return EINVAL for unsupported lseek() operations) posted (#2) for review on release-3.7 by Vijay Bellur (firstname.lastname@example.org)
COMMIT: http://review.gluster.org/13631 committed in release-3.7 by Vijay Bellur (email@example.com)
Author: Niels de Vos <firstname.lastname@example.org>
Date: Tue Mar 8 05:39:01 2016 +0100
gfapi: return EINVAL for unsupported lseek() operations
GlusterFS 3.8 contains support for SEEK_DATA/SEEK_HOLE. This protocol
extension is not available in 3.7. libgfapi needs to handle unsupported
SEEK_* operations correctly, by returning -1 and setting errno to
This change is different from the patch in the master branch, it is only
needed to do the improved error checking in this version.
Signed-off-by: Niels de Vos <email@example.com>
Smoke: Gluster Build System <firstname.lastname@example.org>
Reviewed-by: Shyamsundar Ranganathan <email@example.com>
NetBSD-regression: NetBSD Build System <firstname.lastname@example.org>
CentOS-regression: Gluster Build System <email@example.com>
Reviewed-by: Vijay Bellur <firstname.lastname@example.org>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.9, please open a new bug report.
glusterfs-3.7.9 has been announced on the Gluster mailinglists , packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist  and the update infrastructure for your distribution.