Description of problem: Do not allow directory creations without gfids as it is a pain to fix the gfids. After the directories are created, operations on them fail anyway. So it is better to fail mkdir. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
REVIEW: http://review.gluster.org/13690 (storage/posix: Fail mkdir without gfid-req) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir without gfid-req) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir without gfid-req) posted (#3) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir without gfid-req) posted (#4) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir without gfid-req) posted (#5) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir without gfid-req) posted (#6) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/13776 (features/trash: wind mkdir with special pid) posted (#1) for review on master by Anoop C S (anoopcs)
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions
REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir without gfid-req) posted (#7) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/13776 (features/trash: wind mkdir with special pid) posted (#2) for review on master by Anoop C S (anoopcs)
REVIEW: http://review.gluster.org/13776 (features/trash: wind mkdir with special pid) posted (#3) for review on master by Jeff Darcy (jdarcy)
COMMIT: http://review.gluster.org/13776 committed in master by Jeff Darcy (jdarcy) ------ commit b5cfe948cb3569f034da80ac97b5d2f028b3b0e5 Author: Anoop C S <anoopcs> Date: Fri Mar 18 10:32:09 2016 +0530 features/trash: wind mkdir with special pid Recent changes done w.r.t handling of mkdir calls in posix translator resulted in crashing the brick process from trash translator. This was due to the changes made in posix translator to return EPERM for every mkdir calls without 'gfid-req' set in dictionary. In order to avoid gfid mismatches during directory creation from brick side trash translator does not set 'gfid-req'. This patch is to have an exemption for trash based on a special pid set for those mkdir calls originating from trash translator and to reset it in callback. This patch also includes a small optimization to the existing test case for trash feature. Change-Id: I59f084ac875e54342ecf2bffa6e43ebd84814153 BUG: 1317361 Signed-off-by: Anoop C S <anoopcs> Reviewed-on: http://review.gluster.org/13776 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Jeff Darcy <jdarcy>
REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir without gfid-req) posted (#8) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir without gfid-req) posted (#9) for review on master by Pranith Kumar Karampuri (pkarampu)
COMMIT: http://review.gluster.org/13690 committed in master by Pranith Kumar Karampuri (pkarampu) ------ commit b246b07896fefb261c9fb07f3f29f0d03b81b88d Author: Pranith Kumar K <pkarampu> Date: Mon Mar 14 10:59:38 2016 +0530 dht/afr/client/posix: Fail mkdir without gfid-req Do not allow directory creations without gfids as after the directories are created, operations on them fail anyway. So it is better to fail mkdir. BUG: 1317361 Change-Id: I8f8e3b38bbded1960b7215bac0432500f7e78038 Signed-off-by: Pranith Kumar K <pkarampu> Reviewed-on: http://review.gluster.org/13690 Smoke: Gluster Build System <jenkins.com> Reviewed-by: Krutika Dhananjay <kdhananj> CentOS-regression: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user