Bug 1318676 - Review Request: perl-MooseX-ArrayRef - Blessed array references with Moose
Summary: Review Request: perl-MooseX-ArrayRef - Blessed array references with Moose
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1321042
TreeView+ depends on / blocked
 
Reported: 2016-03-17 13:38 UTC by Petr Pisar
Modified: 2016-03-30 08:00 UTC (History)
2 users (show)

Fixed In Version: perl-MooseX-ArrayRef-0.005-1.fc25
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-03-21 15:50:17 UTC
Type: ---
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2016-03-17 13:38:04 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-MooseX-ArrayRef/perl-MooseX-ArrayRef.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-MooseX-ArrayRef/perl-MooseX-ArrayRef-0.005-1.fc25.src.rpm
Description:
Objects implemented with array references are often faster than those
implemented with hash references. Moose's default object implementation is
hash reference based. This is object implementation based on array references.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-03-18 13:30:52 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-MooseX-ArrayRef-0.005-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl(:VERSION) >= 5.8.0
      1 perl(Moose) >= 2.00
      1 perl(Moose::Exporter)
      1 perl(Moose::Role)
      1 perl(Moose::Util::MetaRole)
      1 perl(MooseX::ArrayRef::Meta::Class)
      1 perl(MooseX::ArrayRef::Meta::Instance)
      1 perl(Scalar::Util)
      1 perl(constant)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-MooseX-ArrayRef-0.005-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(MooseX::ArrayRef) = 0.005
      1 perl(MooseX::ArrayRef::Meta::Class) = 0.005
      1 perl(MooseX::ArrayRef::Meta::Instance) = 0.005
      1 perl-MooseX-ArrayRef = 0.005-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-MooseX-ArrayRef*
perl-MooseX-ArrayRef.noarch: W: invalid-license Artistic
perl-MooseX-ArrayRef.src: W: invalid-license Artistic
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2016-03-21 14:01:58 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-MooseX-ArrayRef

Comment 3 Petr Pisar 2016-03-21 15:50:17 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.