Bug 1318751 - cluster/afr: Fix partial heals in 3-way replication
Summary: cluster/afr: Fix partial heals in 3-way replication
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pranith Kumar K
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1327863
TreeView+ depends on / blocked
 
Reported: 2016-03-17 16:57 UTC by Pranith Kumar K
Modified: 2016-06-16 14:01 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.8rc2
Clone Of:
: 1327863 (view as bug list)
Environment:
Last Closed: 2016-06-16 14:01:05 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Pranith Kumar K 2016-03-17 16:57:18 UTC
Description of problem:
    When there are 2 sources and one sink and if two self-heal daemons
    try to acquire locks at the same time, there is a chance that it
    gets a lock on one source and sink leading partial to heal. This will
    need one more heal from the remaining source to sink for the complete
    self-heal. This is not optimal.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2016-03-17 16:57:55 UTC
REVIEW: http://review.gluster.org/13766 (cluster/afr: Fix partial heals in 3-way replication) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 2 Vijay Bellur 2016-04-12 16:06:17 UTC
REVIEW: http://review.gluster.org/13766 (cluster/afr: Fix partial heals in 3-way replication) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 3 Vijay Bellur 2016-04-15 09:51:10 UTC
COMMIT: http://review.gluster.org/13766 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 8deedef565df49def75083678f8d1558c7b1f7d3
Author: Pranith Kumar K <pkarampu>
Date:   Thu Mar 17 19:42:00 2016 +0530

    cluster/afr: Fix partial heals in 3-way replication
    
    Problem:
    When there are 2 sources and one sink and if two self-heal daemons
    try to acquire locks at the same time, there is a chance that it
    gets a lock on one source and sink leading partial to heal. This will
    need one more heal from the remaining source to sink for the complete
    self-heal. This is not optimal.
    
    Fix:
    Upgrade non-blocking locks to blocking lock on all the subvolumes, if
    the number of locks acquired is majority and there were eagains.
    
    BUG: 1318751
    Change-Id: Iae10b8d3402756c4164b98cc49876056ff7a61e5
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/13766
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Ravishankar N <ravishankar>

Comment 4 Niels de Vos 2016-06-16 14:01:05 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.