Bug 1319873
| Summary: | vdsm FCoE hook should bring fcoe-utils as dependency | ||
|---|---|---|---|
| Product: | [oVirt] vdsm | Reporter: | Pavel Zhukov <pzhukov> |
| Component: | Packaging.rpm | Assignee: | Pavel Zhukov <pzhukov> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Elad <ebenahar> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.18.0 | CC: | acanan, amureini, bugs, danken, nsoffer, pzhukov, ylavi |
| Target Milestone: | ovirt-4.0.0-rc | Flags: | rule-engine:
ovirt-4.0.0+
ylavi: planning_ack+ rule-engine: devel_ack+ acanan: testing_ack+ |
| Target Release: | 4.18.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-01 12:27:46 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1239122, 1334745, 1334748, 1338795 | ||
|
Description
Pavel Zhukov
2016-03-21 17:45:25 UTC
(In reply to Pavel Zhukov from comment #0) > Description of problem: > To properly handle fcoe storages vdsm should depends on fcoe-utils. > ovirt-node iso ships fcoe-utils and lldpad so fcoe can be easily configured > but normal linux host will require to install the package manually > > Version-Release number of selected component (if applicable): > vdsm-4.17.23-0.el7ev.noarch > > Actual results: > fcoe-utils not installed Pavel, looking at your patch: https://gerrit.ovirt.org/#/c/55029/11/vdsm.spec.in The vdsm-hook-fcoe package is requiring fcoe-utils, so after installing this hook, the package should be available on the hypervisor. Vdsm itself does not require this package because it does not need it, and does not interact with any of the fcoe facilities. Can you explain why Vdsm should require this package? (In reply to Nir Soffer from comment #1) > (In reply to Pavel Zhukov from comment #0) > > Description of problem: > > To properly handle fcoe storages vdsm should depends on fcoe-utils. > > ovirt-node iso ships fcoe-utils and lldpad so fcoe can be easily configured > > but normal linux host will require to install the package manually > > > > Version-Release number of selected component (if applicable): > > vdsm-4.17.23-0.el7ev.noarch > > > > Actual results: > > fcoe-utils not installed > > Pavel, looking at your patch: > https://gerrit.ovirt.org/#/c/55029/11/vdsm.spec.in > > The vdsm-hook-fcoe package is requiring fcoe-utils, so after installing this > hook, > the package should be available on the hypervisor. > > Vdsm itself does not require this package because it does not need it, and > does not interact with any of the fcoe facilities. > > Can you explain why Vdsm should require this package? Hi Nir, I'd filed the bug before started to work on the hook. Should I attach gerrit change to this bug or is it better close it? (In reply to Pavel Zhukov from comment #2) > (In reply to Nir Soffer from comment #1) > > (In reply to Pavel Zhukov from comment #0) > > > Description of problem: > > > To properly handle fcoe storages vdsm should depends on fcoe-utils. > > > ovirt-node iso ships fcoe-utils and lldpad so fcoe can be easily configured > > > but normal linux host will require to install the package manually > > > > > > Version-Release number of selected component (if applicable): > > > vdsm-4.17.23-0.el7ev.noarch > > > > > > Actual results: > > > fcoe-utils not installed > > > > Pavel, looking at your patch: > > https://gerrit.ovirt.org/#/c/55029/11/vdsm.spec.in > > > > The vdsm-hook-fcoe package is requiring fcoe-utils, so after installing this > > hook, > > the package should be available on the hypervisor. > > > > Vdsm itself does not require this package because it does not need it, and > > does not interact with any of the fcoe facilities. > > > > Can you explain why Vdsm should require this package? > > Hi Nir, > > I'd filed the bug before started to work on the hook. Should I attach gerrit > change to this bug or is it better close it? Let's keep it to track the fact that the hook should require the fcoe-utils package. Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA. oVirt 4.0 beta has been released, moving to RC milestone. oVirt 4.0 beta has been released, moving to RC milestone. This is already merged - the author should add also this bug url.
Installing the fcoe hook will install fcoe-utils.
commit 16cb9db677c545487ee009fef5b612c0359c8d18
Author: Pavel Zhukov <pzhukov>
AuthorDate: Mon Mar 21 19:24:59 2016 +0100
Commit: Dan Kenigsberg <danken>
CommitDate: Mon May 16 03:43:24 2016 -0400
hooks: Add fcoe hook
This hook is used to enable fcoe on one or several network interfaces
Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Bug-Url: https://bugzilla.redhat.com/1334745
Signed-off-by: Pavel Zhukov <pzhukov>
Reviewed-on: https://gerrit.ovirt.org/55029
Reviewed-by: Dan Kenigsberg <danken>
Continuous-Integration: Jenkins CI
This in included in v4.18.0. vdsm-hook-fcoe requires fcoe-utils as a dependency: # yum deplist vdsm-hook-fcoe package: vdsm-hook-fcoe.noarch 4.18.5.1-1.el7ev dependency: /bin/env provider: coreutils.x86_64 8.22-15.el7_2.1 dependency: fcoe-utils provider: fcoe-utils.x86_64 1.0.30-3.git91c0c8c.el7 dependency: vdsm = 4.18.5.1-1.el7ev provider: vdsm.x86_64 4.18.5.1-1.el7ev =========================================== Used: vdsm-4.18.5.1-1.el7ev.x86_64 vdsm-hook-fcoe-4.18.5.1-1.el7ev.noarch fcoe-utils-1.0.30-3.git91c0c8c.el7.x86_64 |